Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request] Branch per BLE stack? #142

Open
LeeNX opened this issue Oct 23, 2022 · 3 comments
Open

[Feature Request] Branch per BLE stack? #142

LeeNX opened this issue Oct 23, 2022 · 3 comments

Comments

@LeeNX
Copy link

LeeNX commented Oct 23, 2022

Maybe more a suggestion that a feature request, possible to keep both NimBLE and Bluedroid branches on github? I see that NimBLE is in place, but using zip archives files for the Bluedroid stack in issues, must add unneeded overhead for the developer. Switching between branches locally should be easy, thou I am no git guru.

@lemmingDev
Copy link
Owner

Yeah - was going to do that, but ran out of time/motivation last holidays after making an updated Bluedroid version for a few people who were chasing it

@LeeNX
Copy link
Author

LeeNX commented Jul 6, 2023

I was poking at the T-vK/ESP32-BLE-Keyboard and saw that it supports both libs with #if defines, like - https://github.com/T-vK/ESP32-BLE-Keyboard/blob/f8dd4852113a722a6b8dc8af987e94cf84d73ad5/BleKeyboard.cpp#L3.

I was thinking possibly three branchs, like main that supports both with the define and two cleaner branchs for each lib. It's a bit more work, but gives us all three options.

See what I can hack up, soon.

@lemmingDev
Copy link
Owner

Interesting

Any help appreciated!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants