hugo/feature/Move Avatar to AccountKit #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
Feb 21, 2024
HPezz
commented
- 🍱 (AccountKit): Add avatar assets
- ✨ (AccountKit): Get avatars from YAML
- ♻️ (LekaApp): Refactor Avatar with accountkit changes
ladislas
requested changes
Feb 21, 2024
There was a problem hiding this comment.
beau travail! 👍 je sais à quel point c'est laborieux 😂
quelques requests quand même :)
- renommer le dossier
iconsenimages - les noms des images ne doivent avoir que des
_et pas de-
le rename des images peut être fait très facilement avec la cli rename avec un truc genre
cd /path/vers/les/.png
rename 's/-/_/' *.avatars.png- il faut ajouter un pre-commit hook pour valider que les noms des avatars dans le yaml sont bien écrits avec des
_ - il faut ajouter un pre-commit hook pour valider que les fichiers listés dans le yaml existent bien (c'est déjà fait dans un autre hook, il suffit de copier/coller et adapter)
HPezz
force-pushed
the
hugo/feature/Move-Avatar-to-AccountKit
branch
2 times, most recently
from
73826d1 to
15bf302
Compare
ladislas
force-pushed
the
hugo/feature/Move-Avatar-to-AccountKit
branch
from
15bf302 to
c01d958
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.