hugo/refactor/Refactor editProfilesLabel #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
Feb 14, 2024
HPezz
commented
- ♻️ (LekaApp): Refactor titles and texts
- 💄 (LekaApp): Change NoAccount SF symbol color
- 💄 (LekaApp): Add pencil on EditCaregiverLabel
- 💄 (LekaApp): Update Carereceiver View
- 🌐 (LekaApp): Add tracking localization
ladislas
force-pushed
the
hugo/refactor/Refactor-editProfilesLabel
branch
from
203fe9d to
2207509
Compare
ladislas
requested changes
Feb 15, 2024
Apps/LekaApp/Sources/_NEWCodeBase/Views/MainView/NoAccountConnectedLabel.swift
Show resolved
Hide resolved
Comment on lines
21
to
41
| Image(caregiver.avatar, bundle: Bundle(for: DesignKitResources.self)) | ||
| .resizable() | ||
| .aspectRatio(contentMode: .fit) | ||
| .clipShape(Circle()) | ||
| .overlay { | ||
| Image(systemName: "pencil.circle.fill") | ||
| .resizable() | ||
| .renderingMode(.original) | ||
| .frame(maxWidth: 30, maxHeight: 30) | ||
| .foregroundStyle(.orange) | ||
| .padding(5) | ||
| .offset(x: 30, y: -30) | ||
| } | ||
| .frame(maxWidth: 80) | ||
|
|
||
| Text(caregiver.name) | ||
| .font(.headline) | ||
| .frame(maxWidth: 200) | ||
| } | ||
|
|
||
| Divider() |
There was a problem hiding this comment.
j'ai fait un petit update de ça, j'ai rajouté un commits.
j'ai :
- retirer le devider, je suis pas fan et ça allège en fait pas tant que ça
- j'ai bougé le "pencil"
- j'ai changé la couleur du pencil pour être plus discret (orange c'est warning) et mettre en accent color (c'est un bouton en plus)
- j'ai grossi l'image pour qu'il se voit bien
- j'ai mis le bouton de changement en borderless pour qu'il soit plus discret --> je me demande si on devrait pas le mettre dans la toolbar de la side bar, à voir
- j'ai changé l'icon pour faire ressortir le mouvement
As it's more than just monitoring and as it's not available yet, Users sounds better for the moment.
ladislas
force-pushed
the
hugo/refactor/Refactor-editProfilesLabel
branch
from
2207509 to
0f267ed
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.