Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo/feature/Rename RootAccount #675

Merged
merged 2 commits into from
Feb 12, 2024
Merged

hugo/feature/Rename RootAccount #675

merged 2 commits into from
Feb 12, 2024

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Feb 12, 2024

  • 🔥 (LekaApp): Remove Company model from LekaApp
  • ✨ (LekaApp): Add RootAccount model in AccountKit

@HPezz HPezz force-pushed the hugo/feature/Rename-RootAccount branch from f561412 to 9b3f52c Compare February 12, 2024 11:58
ladislas
ladislas requested changes Feb 12, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 juste une petite spécificité pour les UUID

Modules/AccountKit/Sources/Models/RootAccount.swift Outdated
Comment on lines 10 to 11
var id: UUID
var rootOwnerUid: UUID
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

on est en String depuis FB :)

Suggested change
var id: UUID
var rootOwnerUid: UUID
var id: String
var rootOwnerUid: String

@HPezz HPezz self-assigned this Feb 12, 2024
@HPezz HPezz force-pushed the hugo/feature/Rename-RootAccount branch from 9b3f52c to 41dcdfa Compare February 12, 2024 12:36
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@ladislas ladislas merged commit e3a45b3 into main Feb 12, 2024
6 checks passed
@ladislas ladislas deleted the hugo/feature/Rename-RootAccount branch February 12, 2024 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas requested changes

Assignees

@HPezz HPezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HPezz @ladislas