Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo/feature/Update Settings #604

Merged
merged 8 commits into from
Jan 24, 2024
Merged

hugo/feature/Update Settings #604

merged 8 commits into from
Jan 24, 2024

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Jan 19, 2024 •
edited
Loading

  • ✨ (LekaApp): Add Settings button to MainView
  • 🌐 (LekaApp): Add SettingsView l10n file
  • 🚧 (LekaApp): Add temp settings sections
  • ✨ (LekaApp): Add Appearance settings section
  • 🔥 (LekaApp): Remove appearance toggles in MianView
  • 🔥 (DesignKit): Remove unused functions
  • ✨ (LekaApp): Add SettingsView

ladislas
ladislas requested changes Jan 21, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premier passage! c'est pas mal du tout. quelques requests for simplifications et remarques, à discuter demain :)

Modules/DesignKit/Sources/StyleManager.swift Outdated Show resolved Hide resolved
...aApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection+AccentColorRow.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection.swift Outdated Show resolved Hide resolved
...kaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection+AppearanceRow.swift Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Update-Settings branch 2 times, most recently from e355301 to d9332fc Compare January 22, 2024 14:54
@HPezz HPezz changed the base branch from main to hugo/feature/Deprecate-Settings-related-old-code January 22, 2024 14:57
@ladislas ladislas force-pushed the hugo/feature/Deprecate-Settings-related-old-code branch from 4f45847 to 045e142 Compare January 22, 2024 15:04
Base automatically changed from hugo/feature/Deprecate-Settings-related-old-code to main January 22, 2024 15:04
@HPezz HPezz force-pushed the hugo/feature/Update-Settings branch 2 times, most recently from 3b3579d to 084d224 Compare January 23, 2024 10:09
ladislas
ladislas requested changes Jan 23, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

deuxième review :)

ok pour garder les accent colors comme tu as fait mais avec quelques modifications

le but c'est d'avoir les rows de la form qui soient homogènes et fin comme normalement

Apps/LekaApp/Sources/_NEWCodeBase/Views/MainView/MainView.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/MainView/MainView.swift Outdated Show resolved Hide resolved
...aApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection+AccentColorRow.swift Outdated Show resolved Hide resolved
...aApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection+AccentColorRow.swift Outdated Show resolved Hide resolved
...kaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+AppearanceSection+AppearanceRow.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/_NEWCodeBase/Views/Settings/SettingsView+CredentialsSection.swift Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Update-Settings branch from 084d224 to 8f0a545 Compare January 23, 2024 14:50
@HPezz HPezz force-pushed the hugo/feature/Update-Settings branch from 8f0a545 to f7a8e96 Compare January 24, 2024 09:25
@ladislas ladislas merged commit d61f96c into main Jan 24, 2024
4 of 5 checks passed
@ladislas ladislas deleted the hugo/feature/Update-Settings branch January 24, 2024 09:55
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HPezz @ladislas