-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Yann/fix/lekaupdater/colors #573
Conversation
YannLocatelli
commented
Jan 10, 2024
•
edited
Loading
edited
5124992
to
2c447de
Compare
c0c263c
to
c3027b7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
petite request pour le stroke
il faut que tu rebase sur main, j'ai merged un fix pour fastlane et la ci
@@ -6,8 +6,10 @@ import SwiftUI | |||
|
|||
public extension Color { | |||
static let lkBackground: Color = .init(uiColor: .systemGray6) | |||
static let lkNavigationTitle: Color = DesignKitAsset.Colors.lekaDarkBlue.swiftUIColor |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice 👍
@@ -59,8 +59,9 @@ struct InformationView: View { | |||
.padding() | |||
.overlay( | |||
RoundedRectangle(cornerRadius: 20) | |||
.stroke(DesignKitAsset.Colors.lightGray.swiftUIColor, lineWidth: 3) | |||
.stroke(DesignKitAsset.Colors.lekaDarkGray.swiftUIColor, lineWidth: 3) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
du coup dans la même veine que lkNavigationTitle
, tu peux mettre celui ci dans lkStroke
comme ça ça devient universel pour tout le monde :)
c3027b7
to
8fac720
Compare
…(color + padding)
8fac720
to
9abc233
Compare
Quality Gate failedFailed conditions 9.5% Duplication on New Code (required ≤ 3%) |