Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yann/fix/lekaupdater/colors #573

Merged
merged 5 commits into from
Jan 15, 2024
Merged

Yann/fix/lekaupdater/colors #573

merged 5 commits into from
Jan 15, 2024

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Jan 10, 2024

IMG_0458

@YannLocatelli YannLocatelli self-assigned this Jan 10, 2024
@YannLocatelli YannLocatelli force-pushed the yann/fix/lekaupdater/colors branch from 5124992 to 2c447de Compare January 10, 2024 14:08
@YannLocatelli YannLocatelli marked this pull request as draft January 10, 2024 14:08
@YannLocatelli YannLocatelli force-pushed the yann/fix/lekaupdater/colors branch 3 times, most recently from c0c263c to c3027b7 Compare January 12, 2024 18:56
@YannLocatelli
Copy link
Member Author

IMG_0458

@YannLocatelli YannLocatelli marked this pull request as ready for review January 12, 2024 18:57
@YannLocatelli YannLocatelli added the 🧪 fastlane:beta LekaUpdater Fastlane internal beta release for LekaUpdater label Jan 12, 2024
@github-actions github-actions bot removed the 🧪 fastlane:beta LekaUpdater Fastlane internal beta release for LekaUpdater label Jan 12, 2024
@ladislas ladislas added the 🧪 fastlane:beta LekaUpdater Fastlane internal beta release for LekaUpdater label Jan 14, 2024
@github-actions github-actions bot removed the 🧪 fastlane:beta LekaUpdater Fastlane internal beta release for LekaUpdater label Jan 14, 2024
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍
petite request pour le stroke
il faut que tu rebase sur main, j'ai merged un fix pour fastlane et la ci

@@ -6,8 +6,10 @@ import SwiftUI

public extension Color {
static let lkBackground: Color = .init(uiColor: .systemGray6)
static let lkNavigationTitle: Color = DesignKitAsset.Colors.lekaDarkBlue.swiftUIColor
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice 👍

@@ -59,8 +59,9 @@ struct InformationView: View {
.padding()
.overlay(
RoundedRectangle(cornerRadius: 20)
.stroke(DesignKitAsset.Colors.lightGray.swiftUIColor, lineWidth: 3)
.stroke(DesignKitAsset.Colors.lekaDarkGray.swiftUIColor, lineWidth: 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

du coup dans la même veine que lkNavigationTitle, tu peux mettre celui ci dans lkStroke comme ça ça devient universel pour tout le monde :)

@YannLocatelli YannLocatelli force-pushed the yann/fix/lekaupdater/colors branch from c3027b7 to 8fac720 Compare January 15, 2024 10:07
@YannLocatelli YannLocatelli force-pushed the yann/fix/lekaupdater/colors branch from 8fac720 to 9abc233 Compare January 15, 2024 10:08
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions

9.5% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

@YannLocatelli YannLocatelli added the 🧪 fastlane:beta LekaUpdater Fastlane internal beta release for LekaUpdater label Jan 15, 2024
@github-actions github-actions bot removed the 🧪 fastlane:beta LekaUpdater Fastlane internal beta release for LekaUpdater label Jan 15, 2024
@ladislas ladislas merged commit a4d4a47 into main Jan 15, 2024
7 of 8 checks passed
@ladislas ladislas deleted the yann/fix/lekaupdater/colors branch January 15, 2024 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants