Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo/feature/Handle Exercise status and displays it #567

Merged
merged 5 commits into from
Jan 10, 2024
Merged

hugo/feature/Handle Exercise status and displays it #567

merged 5 commits into from
Jan 10, 2024

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Jan 5, 2024

  • ✨ (GEK): Add ExerciseResult enum
  • ♻️ (GEK): Add ExerciseResult as .completed parameter
  • ♻️ (GEK): Add allowedTrials notion in generic gameplays
  • ♻️ (GEK): Add parameters to ExerciceSharedData
  • ♻️ (GEK): Compute final score percentage

@HPezz HPezz requested a review from ladislas January 5, 2024 16:47
@HPezz HPezz self-assigned this Jan 5, 2024
@HPezz HPezz linked an issue Jan 5, 2024 that may be closed by this pull request
handle exercise complete status (green, orange, red) and display in progress bar + lottie animation #563
Closed
@HPezz HPezz force-pushed the hugo/feature/Handle-Exercise-status-and-displays-it branch from 8eff9d6 to 0603f60 Compare January 5, 2024 16:58
ladislas
ladislas requested changes Jan 7, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

premier passage, c'est très intéressant! 👍

Modules/GameEngineKit/Sources/_NewSystem/Exercises/ExerciseResult.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Exercises/ExerciseResult.swift Outdated Show resolved Hide resolved
...urces/_NewSystem/Gameplays/AssociateCategories/GameplayAssociateCategories+DragAndDrop.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Gameplays/GameplayChoiceModels.swift Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Handle-Exercise-status-and-displays-it branch 6 times, most recently from 1222e8d to a7c5904 Compare January 9, 2024 15:40
ladislas
ladislas requested changes Jan 10, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

belle implémentation, well done! 👍

j'ai mis pas mal de requests/remarques/questions, plus sur la forme que sur le fond, afin de rendre la lecture plus digeste, dispo pour en parler si besoin :)

...eEngineKit/Sources/_NewSystem/Exercises/Specialized/HideAndSeek/HideAndSeekView+Player.swift Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityProgressBar.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityProgressBar.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityProgressBar.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityView.swift Outdated Show resolved Hide resolved
...ces/_NewSystem/Gameplays/FindTheRightAnswers/GameplayFindTheRightAnswers+TouchToSelect.swift Show resolved Hide resolved
...wSystem/Gameplays/FindTheRightAnswers/GameplayFindTheRightAnswers+DragAndDropIntoZones.swift Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityProgressBar.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityProgressBar.swift Outdated Show resolved Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/Activity/ActivityProgressBar.swift Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Handle-Exercise-status-and-displays-it branch 2 times, most recently from 988f9fa to 651af62 Compare January 10, 2024 16:23
@ladislas ladislas force-pushed the hugo/feature/Handle-Exercise-status-and-displays-it branch from 651af62 to 60204e7 Compare January 10, 2024 17:12
@ladislas ladislas merged commit bb26b05 into main Jan 10, 2024
5 checks passed
@ladislas ladislas deleted the hugo/feature/Handle-Exercise-status-and-displays-it branch January 10, 2024 17:13
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

9 New issues
0 Security Hotspots
No data about Coverage
0.8% Duplication on New Code

See analysis details on SonarCloud

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

Assignees

@HPezz HPezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

handle exercise complete status (green, orange, red) and display in progress bar + lottie animation
2 participants
@HPezz @ladislas