hugo/feature/Add Pairing #536
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
Dec 13, 2023
HPezz
commented
- ✨ (GEK): Add PlayerButton to Melody
- 🔥 (GEK): Remove oldSystem PairingView
- ♻️ (RobotKit): Add custom Color init rgb and gradient
- x:sparkles: (GEK): Add Pairing views
- ✨ (ContentKitxUIExplorer): Add Pairing activity
HPezz
force-pushed
the
hugo/feature/Add-Pairing
branch
from
f2c27a0 to
aefaeb8
Compare
HPezz
added
fastlane:rbi LekaActivityUIExplorer
and removed
fastlane:rbi LekaActivityUIExplorer
labels
HPezz
force-pushed
the
hugo/feature/Add-Pairing
branch
5 times, most recently
from
dd86422 to
b8c25bd
Compare
HPezz
force-pushed
the
hugo/feature/Add-Pairing
branch
from
b8c25bd to
9e23b6b
Compare
ladislas
requested changes
Dec 21, 2023
...s/GameEngineKit/Sources/_NewSystem/Exercises/Specialized/Pairing/PairingView+Animation.swift
Outdated
Show resolved
Hide resolved
Comment on lines
+34
to
+45
| public init(fromGradient colors: (Color, Color), at position: Float) { | ||
| let positionClamped = max(min(position, 1), 0) | ||
| let (r1, g1, b1) = (Float(colors.0.robotRGB[0]), Float(colors.0.robotRGB[1]), Float(colors.0.robotRGB[2])) | ||
| let (r2, g2, b2) = (Float(colors.1.robotRGB[0]), Float(colors.1.robotRGB[1]), Float(colors.1.robotRGB[2])) | ||
|
|
||
| let r = UInt8(r1 + (r2 - r1) * positionClamped) | ||
| let g = UInt8(g1 + (g2 - g1) * positionClamped) | ||
| let b = UInt8(b1 + (b2 - b1) * positionClamped) | ||
|
|
||
| self.robotRGB = [r, g, b] | ||
| self.screenRGB = [r, g, b] | ||
| } |
There was a problem hiding this comment.
je sais plus si on en avait parlé à l'oral ou si j'avais déjà mis dans une précédente review, mais je pense que ça serait mieux de sortir ça dans une struct Gradient à part
l'idée est de créer un gradient avec le nombre de couleur que tu veux puis ensuite d'itérer dessus comme pour un array
HPezz
force-pushed
the
hugo/feature/Add-Pairing
branch
2 times, most recently
from
b00378b to
0ecbd35
Compare
ladislas
force-pushed
the
hugo/feature/Add-Pairing
branch
from
0ecbd35 to
2ae8a43
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.