-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚸 (UIExplorer): Refactor navigation to use split view #517
Merged
ladislas
merged 7 commits into
main
from
ladislas/feature/uiexplorer-splitview-navigation
Dec 7, 2023
Merged
🚸 (UIExplorer): Refactor navigation to use split view #517
ladislas
merged 7 commits into
main
from
ladislas/feature/uiexplorer-splitview-navigation
Dec 7, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ladislas
force-pushed
the
ladislas/feature/uiexplorer-splitview-navigation
branch
from
December 7, 2023 09:20
5313367
to
831e212
Compare
ladislas
force-pushed
the
ladislas/feature/uiexplorer-splitview-navigation
branch
from
December 7, 2023 09:23
831e212
to
7cbe2e3
Compare
HPezz
reviewed
Dec 7, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few remarks on naming details
Apps/LekaActivityUIExplorer/Sources/Navigation/Navigation.swift
Outdated
Show resolved
Hide resolved
ladislas
force-pushed
the
ladislas/feature/uiexplorer-splitview-navigation
branch
from
December 7, 2023 10:06
fc5fccc
to
8f232d8
Compare
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.