Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hugo/feature/Add Xylophone #504

Merged
merged 1 commit into from
Nov 29, 2023
Merged

hugo/feature/Add Xylophone #504

merged 1 commit into from
Nov 29, 2023

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Nov 29, 2023

  • 🔥 (GEK): Remove old Xylophone and MIDI system
  • ✨ (GEK): Add MIDIPlayer and MIDISample to Utils
  • ✨ (GEK): Add InstrumentView and Xylophone views
  • ✨ (ContentKitxUIExplorer): Add Xylophone activities
  • 🗑️ (GEK): Update staging Melody to system changes

@HPezz HPezz self-assigned this Nov 29, 2023
@HPezz HPezz force-pushed the hugo/feature/Add-Xylophone branch from 39fdf20 to 3b09a55 Compare November 29, 2023 15:07
@HPezz HPezz requested a review from ladislas November 29, 2023 15:07
@HPezz HPezz linked an issue Nov 29, 2023 that may be closed by this pull request
@HPezz HPezz force-pushed the hugo/feature/Add-Xylophone branch from 3b09a55 to c979c94 Compare November 29, 2023 16:16
@ladislas ladislas force-pushed the hugo/feature/Add-Xylophone branch from c979c94 to 5322f78 Compare November 29, 2023 23:05
- add MIDI files to Utils
- remove old Xylophone and MIDI system
- add Instrument and Xylophone views
- start to deprecate old system Melody with changes
@ladislas ladislas force-pushed the hugo/feature/Add-Xylophone branch from 5322f78 to 55ba4bc Compare November 29, 2023 23:15
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

@ladislas ladislas merged commit 5f15a47 into main Nov 29, 2023
5 of 6 checks passed
@ladislas ladislas deleted the hugo/feature/Add-Xylophone branch November 29, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Specialized - Add Xylophone activity
2 participants