Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Yann/feature/lekaupdater/redirection to my leka alpha #460

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Yann/feature/lekaupdater/redirection to my leka alpha #460

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c7df85a
:wrench: (LekaUpdater): Allow use of MyLekaAlpha URL scheme
YannLocatelli Nov 13, 2023
82ee0ce
:globe_with_meridians: (LekaUpdater): Replace Launch Leka App by Laun…
YannLocatelli Nov 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion Apps/LekaUpdater/Project.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,9 @@ let project = Project.iOSApp(
"CFBundleURLSchemes": ["LekaUpdater"],
]
],
"LSApplicationQueriesSchemes": ["LekaApp"],
"LSApplicationQueriesSchemes": [
"LekaApp", "com.googleusercontent.apps.224911845933-mv4tp4rstgjtvdqvbv5dl7defii1a7ic",
],
],
schemes: schemes
)
4 changes: 2 additions & 2 deletions Apps/LekaUpdater/Resources/ll10n/Localizable.xcstrings
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -690,13 +690,13 @@
"en" : {
"stringUnit" : {
"state" : "new",
"value" : "Launch Leka App 🚀"
"value" : "Launch My Leka Alpha 🚀"
}
},
"fr" : {
"stringUnit" : {
"state" : "translated",
"value" : "Lancer Leka App 🚀"
"value" : "Lancer Mon Leka Alpha 🚀"
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion Apps/LekaUpdater/Sources/Localization.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,7 +167,7 @@ extension l10n {

static let updateAnotherRobotButton = LocalizedString("update.finished.update_another_robot_button", value: "Update another robot", comment: "Update another robot button")

static let launchLekaAppButton = LocalizedString("update.finished.launch_leka_app_button", value: "Launch Leka App 🚀", comment: "Launch Leka app button")
static let launchLekaAppButton = LocalizedString("update.finished.launch_leka_app_button", value: "Launch My Leka Alpha 🚀", comment: "Launch Leka app button")

static let robotUpdatedSuccessfully = LocalizedString("update.finished.robot_updated_successfully", value: "Congrats! 🥳\nYour robot is now up-to-date 🎉", comment: "Robot updated successfully")
}
Expand Down
5 changes: 3 additions & 2 deletions Apps/LekaUpdater/Sources/View/UpdatingViews/UpdateFinishedView.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ struct UpdateFinishedContentView: View {
}

Button {
let appURL = URL(string: "LekaApp://")
let appStoreURL = URL(string: "https://apps.apple.com/fr/app/mon-leka-alpha/id1607862221")!
let appURL = URL(
string: "com.googleusercontent.apps.224911845933-mv4tp4rstgjtvdqvbv5dl7defii1a7ic://")
let appStoreURL = URL(string: "https://apps.apple.com/app/mon-leka-alpha/id1607862221")!

if let appURL = appURL, UIApplication.shared.canOpenURL(appURL) {
UIApplication.shared.open(appURL, options: [:], completionHandler: nil)
Expand Down