ladislas/feature/contentkit refactor activity exercise data models #456
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ladislas
commented
Nov 13, 2023
ladislas
commented
- 🚨 (ContentKit): Sonarcloud - Rename "activity" which has the same name as the field
- 🚚 (ContentKit): Reorganize files between Activity and exercise
- ♻️ (ContentKit): Move ExerciseSequence inside Exercise
- ♻️ (ContentKit): Rename ExerciseType to Category + move to Exercise
- 🗃️ (ContentKit): Rename type to category in yaml files
- ♻️ (ContentKit): Move Action to Exercise
- ♻️ (ContentKit): Move Gameplay to Exercise
- ♻️ (ContentKit): Move Payload to Exercise
- ♻️ (ContentKit): Action - Replace robot/iPadMedia by ActionType
- ♻️ (ContentKit): Rename SelectionChoice to TouchSelectionChoice
- ♻️ (ContentKit): Rename SelectionPayload to TouchSelectionPayload
- 🚚 (ContentKit): Rename DragAndDropSelection to DragAndDropIntoZones
- ♻️ (ContentKit): Rename DragAndDropChoice to DragAndDropIntoZonesChoice
- ♻️ (ContentKit): Rename ChoiceDropZone to DropZone
- ♻️ (ContentKit): Rename DragAndDropPayload to DragAndDropIntoZonesPayload
- ♻️ (ContentKit): DragAndDropIntoZones - create enum, move all
- ⚗️ (ContentKit): DragAndDropAssociation - Add basic enum to hold things
- ♻️ (ContentKit): TouchSelection - create enum, move all
ladislas
force-pushed
the
ladislas/feature/contentkit-refactor-activity-exercise-data-models
branch
from
28922af to
80c7aa3
Compare
HPezz
requested changes
Nov 14, 2023
Modules/ContentKit/Sources/Exercise/Exercise+DragAndDropAssociation.swift
Outdated
Show resolved
Hide resolved
Modules/ContentKit/Sources/Exercise/Exercise+DragAndDropAssociation.swift
Show resolved
Hide resolved
Modules/ContentKit/Sources/Exercise/Exercise+DragAndDropAssociation.swift
Outdated
Show resolved
Hide resolved
|
|
||
| // swiftlint:disable nesting | ||
|
|
||
| public enum DragAndDropIntoZones { |
There was a problem hiding this comment.
I'm not a huge fan of this naming. It feels weird next to TouchToSelect, TouchToAssociate, DragAndDropToAssociate that end with a verb. Can it be DragAndDropToAllocate or another verb to describe what we do ?
There was a problem hiding this comment.
me neither, but I'm out of ideas for this name. It's not the same as the others, but at the same time I'm not sure we'll be able to always keep this this way. When we'll work on sequencing, or something else, names might differ.
I don't want to have just "drag and drop" as it seems it's on top of the others.
I'll keep this for the moment, we can revisit at a later time if needed when something pops up.
Modules/ContentKit/Sources/Exercise/Exercise+TouchAssociation.swift
Outdated
Show resolved
Hide resolved
ladislas
force-pushed
the
ladislas/feature/contentkit-refactor-activity-exercise-data-models
branch
from
80c7aa3 to
87a63a3
Compare
ladislas
force-pushed
the
ladislas/feature/contentkit-refactor-activity-exercise-data-models
branch
from
87a63a3 to
3eda5df
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
ladislas
deleted the
ladislas/feature/contentkit-refactor-activity-exercise-data-models
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.