ladislas/feature/robotkit #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
ladislas
commented
Sep 25, 2023
ladislas
commented
- 🔥 (RobotKit): Example app - Start again with wire frame
- ✨ (RobotKitExample): Add Robot Control views
- ✨ (RobotKitExample): Implement connected robot information view + vm
- ✨ (RobotKit): Add Magic Cards + tests
- ✨ (RobotKit): Add first (empty) implementation of Robot class
ladislas
force-pushed
the
ladislas/feature/robotkit
branch
from
3da15ce to
642b9ad
Compare
HPezz
requested changes
Sep 27, 2023
Comment on lines
9
to
23
| public enum Lights { | ||
| case full | ||
| case halfLeft | ||
| case halfRight | ||
| case quarterFrontLeft | ||
| case quarterFrontRight | ||
| case quarterBackLeft | ||
| case quarterBackRight | ||
|
|
||
| case range(start: Int, end: Int) | ||
| case spot(ids: [Int]) | ||
|
|
||
| } |
There was a problem hiding this comment.
You can add leftEar and rightEar and, if needed, bothEars to the Lights enum
ladislas
force-pushed
the
ladislas/feature/robotkit
branch
3 times, most recently
from
88d865f to
0f418f2
Compare
ladislas
force-pushed
the
ladislas/feature/robotkit
branch
from
0f418f2 to
44a4f9e
Compare
This commit defines the public interface of the Robot class Methods don't do anything except from printing to the console. Detailed implementation will follow
- replace by hand made - add preview to RobotControlActionButton - remove print from RobotControlActionButton
ladislas
force-pushed
the
ladislas/feature/robotkit
branch
from
44a4f9e to
b7e3b60
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.