hugo/feature/Add action to DnDGrid in NewGEK #1649
Conversation
HPezz
commented
Dec 13, 2024
HPezz
commented
- ✨ (NewGEK): Add DnDGridUIModel
- 🧑💻 (NewGEK): Add new image choices set
- ♻️ (NewGEK): GridCoordinator use GridUIModel
- ♻️ (NewGEK): GridVM use coordinator's uiModel
- ♻️ (NewGEK): DnDGrid now can display or not action
- ♻️ (NewGEK): Display all sorts of actionThenDnDGrid
HPezz
force-pushed
the
hugo/feature/Add-ActionThenDnD-to-NewGEK
branch
from
ffd1cc4 to
75df390
Compare
HPezz
changed the title
Modules/GameEngineKit/Sources/_NewSystem/Views/DnD/Grid/DnDGridUIModel.swift
Outdated
Show resolved
Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/DnD/Grid/DnDGridUIModel.swift
Outdated
Show resolved
Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/DnD/Grid/DnDGridUIModel.swift
Outdated
Show resolved
Hide resolved
| @@ -31,6 +60,16 @@ public struct DnDGridView: View { | |||
| @StateObject private var viewModel: DnDGridViewModel | |||
| @State private var scene: SKScene = .init() | |||
|
|
|||
| private var standardDnDGridView: some View { | |||
There was a problem hiding this comment.
I think you can omit the standard and just have dndGridView or even gridView
I'm not sure if it's possible but for first class citizens like this, I would prefer to see (DnD)GridView as a struct with the needed parameters.
this allows for code reuse and when reading the code it makes it clear that this part is important and not just a local variable: this is where everything happens
There was a problem hiding this comment.
the scene logic can be moved to a specific class
There was a problem hiding this comment.
with that said, the current name DnDGridView for the file it a bit to narrow now that we added the action part. it's not just about the grid anymore.
maybe DnDExerciseViewGrid might be more suited as it's a full exercise now.
we would then have DnDExerciseViewGridWithZones, DnDExerciseViewOneToOne, etc.
ladislas
force-pushed
the
hugo/feature/Add-ActionThenDnD-to-NewGEK
branch
from
f8c01d3 to
0bd2e74
Compare
|
