hugo/feature/Add DnDInOrder in new GEK #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HPezz
commented
Nov 29, 2024
•
HPezz
commented
- ✨ (New GEK): Upgrade AnswerNode UI
- ✨ (New GEK): Add new DropZoneNode init with a node
- 🐛 (New GEK): Fix RightOrder GP's bug
- ✨ (New GEK): Add new set of FindTheRightOrder choices
- 🚸 (GEK ): Smooth snapToCenter movement with SKAction
- ✨ (New GEK): Add DnDGridWithCorrespondingZonesGameplayCoordinatorProtocol
- ✨ (New GEK): Add DnDGridWithCorrespondingZonesCoordinatorFindTheRightOrder
- ✨ (New GEK): Add DnDGridWithCorrespondingZones VM
- ✨ (New GK): Add DnDGridWithCorrespondingZones views
- ✨ (GEKExample): Add Sequencing exercise
- 🚚 (New GEK): Renaming into DnDOneToOne
- ♻️ (New GEK): Allow shuffling in sequencing
- 🎨 (New GEK): Refactor DnDOneToOneCoordinatorFindTheRightOrder
- 🐛 (New GEK): Fix choice size variable bug
HPezz
force-pushed
the
hugo/feature/Add-DnDInOrder-in-new-GEK
branch
4 times, most recently
from
74362dd to
883ccaf
Compare
ladislas
approved these changes
Dec 3, 2024
There was a problem hiding this comment.
très bon boulot!
j'ai finalement pas grand chose à dire 😂 mais j'ai quelques questions par curiosité :)
à rediscuter demain
pour le naming je sais pas si DnDOneToOne suffit ou si DnDIntoZonesOneToOne est mieux voir même DnDToAssociateOneToOne
je trouve qu'il y a un peu un questionnement là dessus à discuter aussi :)
Modules/GameEngineKit/Sources/_NewSystem/Views/DnD/SKComponents/DnDAnswerNode.swift
Outdated
Show resolved
Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Views/DnD/SKComponents/DnDDropZoneNode.swift
Outdated
Show resolved
Hide resolved
Modules/GameEngineKit/Sources/_NewSystem/Gameplays/NewGameplayFindTheRightOrder.swift
Show resolved
Hide resolved
...les/GameEngineKit/Sources/_NewSystem/Views/DnD/OneToOne/BaseScene/DnDOneToOneBaseScene.swift
Outdated
Show resolved
Hide resolved
HPezz
force-pushed
the
hugo/feature/Add-DnDInOrder-in-new-GEK
branch
from
883ccaf to
37480e7
Compare
ladislas
force-pushed
the
hugo/feature/Add-DnDInOrder-in-new-GEK
branch
from
37480e7 to
2a56bfb
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.