Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hugo/feature/Add OS update available alert #1599

Merged
merged 5 commits into from
Nov 28, 2024
Merged

hugo/feature/Add OS update available alert #1599

merged 5 commits into from
Nov 28, 2024

Conversation

HPezz
Copy link
Contributor

@HPezz HPezz commented Nov 26, 2024

  • 🔊 (AnalyticsKit): Add OS update alert log events
  • ✨ (LekaApp): Add OS update available check
  • 🚸 (LekaApp): Add OS update available alert

@HPezz HPezz requested a review from ladislas November 26, 2024 13:51
@HPezz HPezz self-assigned this Nov 26, 2024
@HPezz HPezz force-pushed the hugo/feature/Add-OS-update-available-alert branch from 9382a30 to 933ee26 Compare November 26, 2024 14:14
ladislas
ladislas requested changes Nov 26, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM sur le fonctionnement 👍 j'ai proposé quelques changements sur les texts et un peu sur le code :)
la parti skip vs remind later est intéressante

Apps/LekaApp/Sources/MainApp.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/MainApp.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Resources/l10n/Localizable.xcstrings Outdated Show resolved Hide resolved
Apps/LekaApp/Resources/l10n/Localizable.xcstrings Outdated Show resolved Hide resolved
Apps/LekaApp/Resources/l10n/Localizable.xcstrings Outdated Show resolved Hide resolved
Apps/LekaApp/Resources/l10n/Localizable.xcstrings Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/MainApp.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/MainApp.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/Views/MainView/MainView.swift Outdated Show resolved Hide resolved
Modules/AnalyticsKit/Sources/Analytics/AnalyticsManager.swift Outdated Show resolved Hide resolved
@HPezz HPezz force-pushed the hugo/feature/Add-OS-update-available-alert branch 3 times, most recently from d71cba0 to 41247d0 Compare November 27, 2024 09:49
@ladislas ladislas force-pushed the hugo/feature/Add-OS-update-available-alert branch from 41247d0 to 1bf32f9 Compare November 28, 2024 15:55
HPezz
HPezz commented Nov 28, 2024
View reviewed changes
Copy link
Contributor Author

@HPezz HPezz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deux petits changement clés mais après c'est good to merge

Apps/LekaApp/Sources/MainApp.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/MainApp.swift Outdated Show resolved Hide resolved
Apps/LekaApp/Sources/Views/MainView/MainView.swift Outdated Show resolved Hide resolved
@ladislas ladislas force-pushed the hugo/feature/Add-OS-update-available-alert branch from 1bf32f9 to 3c6d283 Compare November 28, 2024 16:13
@ladislas ladislas force-pushed the hugo/feature/Add-OS-update-available-alert branch from 3c6d283 to c404e9b Compare November 28, 2024 16:25
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
4 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@ladislas ladislas merged commit c3845a4 into develop Nov 28, 2024
5 of 8 checks passed
@ladislas ladislas deleted the hugo/feature/Add-OS-update-available-alert branch November 28, 2024 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas requested changes

Assignees

@HPezz HPezz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@HPezz @ladislas