mathieu/feature/Add Analytics recommanded logEvents #1548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
macteuts
force-pushed
the
mathieu/feature/Add-Analytics-recommanded-logEvents
branch
from
73f7f90 to
ed35604
Compare
ladislas
requested changes
Nov 2, 2024
There was a problem hiding this comment.
Ca me semble top!
Pour les defaults parameters est-ce qu'on utiliserait pas cette fonction ?
https://firebase.google.com/docs/analytics/events?platform=ios#set_default_event_parameters_3
Dans la partie log event il y a aussi une implémentation pour select content qui est pas mal en utilisant les vrais trucs de firebase
https://firebase.google.com/docs/analytics/events?platform=ios#log_events_4
ladislas
requested changes
Nov 2, 2024
macteuts
force-pushed
the
mathieu/feature/Add-Analytics-recommanded-logEvents
branch
9 times, most recently
from
3971bcc to
82a7de7
Compare
macteuts
force-pushed
the
mathieu/feature/Add-Analytics-recommanded-logEvents
branch
from
82a7de7 to
a0a446c
Compare
ladislas
force-pushed
the
mathieu/feature/Add-Analytics-recommanded-logEvents
branch
from
8c99836 to
69ea946
Compare
ladislas
deleted the
mathieu/feature/Add-Analytics-recommanded-logEvents
branch
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.