Skip to content

Commit

Permalink
🔀️ Merge branch 'ladislas/bugfix/remove-implicit-dependencies' into d…
Browse files Browse the repository at this point in the history
…evelop
  • Loading branch information
ladislas committed Nov 28, 2024
2 parents 1651140 + 6fa4fc1 commit 40ded88
Show file tree
Hide file tree
Showing 94 changed files with 377 additions and 314 deletions.
1 change: 1 addition & 0 deletions .github/workflows/ci-fastlane-release_app_store.yml
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,7 @@ jobs:
- name: Setup mise
run: |
echo "$HOME/.local/share/mise/shims" >> $GITHUB_PATH
mise install
- uses: actions/cache@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-fastlane-release_beta_internal.yml
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,7 @@ jobs:
- name: Setup mise
run: |
echo "$HOME/.local/share/mise/shims" >> $GITHUB_PATH
mise install
- uses: actions/cache@v4
with:
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-linter-swiftformat.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- name: Setup mise
run: |
echo "$HOME/.local/share/mise/shims" >> $GITHUB_PATH
mise install
- name: Run swiftformat
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-linter-swiftlint.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,6 +29,7 @@ jobs:
- name: Setup mise
run: |
echo "$HOME/.local/share/mise/shims" >> $GITHUB_PATH
mise install
- name: Run swiftlint
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-tuist-build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ jobs:
- name: Setup mise
run: |
echo "$HOME/.local/share/mise/shims" >> $GITHUB_PATH
mise install
- name: tuist install
run: |
Expand Down
1 change: 1 addition & 0 deletions .github/workflows/ci-tuist-unit_tests.yml
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ jobs:
- name: Setup mise
run: |
echo "$HOME/.local/share/mise/shims" >> $GITHUB_PATH
mise install
- name: tuist install
run: |
Expand Down
6 changes: 3 additions & 3 deletions .mise.toml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
[tools]
swiftlint = "0.57.0"
tuist = "4.33.0"
swiftformat = "0.54.6"
swiftlint = "0.57.1"
tuist = "4.36.0"
swiftformat = "0.55.3"
1 change: 1 addition & 0 deletions Apps/LekaApp/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ let project = Project.app(
.external(name: "DeviceKit"),
.external(name: "Fit"),
.external(name: "MarkdownUI"),
.external(name: "Version"),
.external(name: "Yams"),
],
scripts: [
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -70,6 +70,7 @@ extension AccountCreationProcess {
@StateObject private var caregiverManagerViewModel = CaregiverManagerViewModel()

@State private var isCaregiverCreationPresented: Bool = false

private let caregiverManager: CaregiverManager = .shared
}
}
Expand Down
1 change: 1 addition & 0 deletions Apps/LekaApp/Sources/Views/AvatarPicker/AvatarPicker.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ struct AvatarPicker: View {

@Environment(\.dismiss) var dismiss
@State var selectedAvatar: String = ""

let onCancel: (() -> Void)?
let onSelect: ((String) -> Void)?

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -22,6 +22,7 @@ struct ProfessionPicker: View {

@Environment(\.dismiss) var dismiss
@State var selectedProfessions: Set<Profession> = []

let selectedProfessionsIDs: [String]
let onCancel: (() -> Void)?
let onSelect: (([String]) -> Void)?
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -56,8 +56,9 @@ struct CarereceiverAvatarCell: View {

// MARK: Private

private let strokeColor: Color = .init(light: UIColor.systemGray3, dark: UIColor.systemGray2)
@ObservedObject private var styleManager: StyleManager = .shared

private let strokeColor: Color = .init(light: UIColor.systemGray3, dark: UIColor.systemGray2)
}

#Preview {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -96,13 +96,13 @@ struct CarereceiverPicker: View {
case skip
}

private let columns = Array(repeating: GridItem(spacing: -20), count: 4)

@StateObject private var carereceiverManagerViewModel = CarereceiverManagerViewModel()
@ObservedObject private var navigation: Navigation = .shared
@State private var selectedCarereceiver: [Carereceiver]
@State private var action: ActionType?

private let columns = Array(repeating: GridItem(spacing: -20), count: 4)

private var noCarereceiverView: some View {
VStack {
Text(l10n.CarereceiverPicker.CreateFirstCarereceiver.message)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,7 @@ struct CreateCarereceiverView: View {
// MARK: Internal

@Environment(\.dismiss) var dismiss

var onClose: (() -> Void)?

var carereceiverManager: CarereceiverManager = .shared
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -49,6 +49,7 @@ struct CreateCaregiverView: View {
// MARK: Internal

@Environment(\.dismiss) var dismiss

var onClose: (() -> Void)?

var caregiverManager: CaregiverManager = .shared
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -126,14 +126,14 @@ struct EditCaregiverView: View {
@FocusState private var focused: Bool
@State private var isWhitespacesErrorMessageVisible = false

private var caregiverManager: CaregiverManager = .shared

@StateObject private var viewModel: EditCaregiverViewViewModel
@StateObject private var caregiverManagerViewModel = CaregiverManagerViewModel()

@ObservedObject private var styleManager: StyleManager = .shared
@State private var birthdate: Date

private var caregiverManager: CaregiverManager = .shared

private var placeholderFirstName = Text(String(l10n.CaregiverCreation.caregiverPlaceholderFirstName.characters))

private var placeholderLastName = Text(String(l10n.CaregiverCreation.caregiverPlaceholderLastName.characters))
Expand Down
2 changes: 2 additions & 0 deletions Apps/LekaUpdater/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -44,5 +44,7 @@ let project = Project.app(
.project(target: "DesignKit", path: Path("../../Modules/DesignKit")),
.project(target: "LocalizationKit", path: Path("../../Modules/LocalizationKit")),
.project(target: "RobotKit", path: Path("../../Modules/RobotKit")),

.external(name: "Version"),
]
)
Original file line number Diff line number Diff line change
Expand Up @@ -69,9 +69,9 @@ struct RobotDiscoveryView: View {

// MARK: Private

private var discovery: RobotDiscoveryModel

// MARK: - Environment variables

@EnvironmentObject private var robotListViewModel: RobotListViewModel

private var discovery: RobotDiscoveryModel
}
4 changes: 2 additions & 2 deletions Modules/ContentKit/Sources/Views/ActivityDetailsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -175,15 +175,15 @@ public struct ActivityDetailsView: View {

// MARK: Private

private let activity: Activity

@State private var selectedAuthor: Author?
@State private var selectedSkill: Skill?

@ObservedObject private var styleManager: StyleManager = .shared

@StateObject private var rootAccountViewModel = RootAccountManagerViewModel()
@StateObject private var caregiverManagerViewModel = CaregiverManagerViewModel()

private let activity: Activity
}

// MARK: - l10n.ActivityDetailsView
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/ActivityGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -68,8 +68,9 @@ public struct ActivityGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 3)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 3)
}

#Preview {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -64,9 +64,10 @@ public struct ActivityHorizontalListView: View {

// MARK: Private

@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 3)
private let rows = [GridItem()]
@ObservedObject private var styleManager: StyleManager = .shared
}

#Preview {
Expand Down
4 changes: 2 additions & 2 deletions Modules/ContentKit/Sources/Views/CurriculumDetailsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -187,15 +187,15 @@ public struct CurriculumDetailsView: View {

// MARK: Private

private let curriculum: Curriculum

@State private var selectedAuthor: Author?
@State private var selectedSkill: Skill?
@State private var isDescriptionExpanded = false
@ObservedObject private var styleManager: StyleManager = .shared

@StateObject private var rootAccountViewModel = RootAccountManagerViewModel()
@StateObject private var caregiverManagerViewModel = CaregiverManagerViewModel()

private let curriculum: Curriculum
}

// MARK: - l10n.CurriculumDetailsView
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/CurriculumGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -52,8 +52,9 @@ public struct CurriculumGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 3)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 3)
}

#Preview {
Expand Down
4 changes: 2 additions & 2 deletions Modules/ContentKit/Sources/Views/CurriculumGroupboxView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -109,12 +109,12 @@ public struct CurriculumGroupboxView: View {

// MARK: Private

private let curriculum: Curriculum

@ObservedObject private var styleManager: StyleManager = .shared

@StateObject private var rootAccountViewModel = RootAccountManagerViewModel()
@StateObject private var caregiverManagerViewModel = CaregiverManagerViewModel()

private let curriculum: Curriculum
}

// MARK: - l10n.CurriculumGroupboxView
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,10 @@ public struct CurriculumHorizontalListView: View {

// MARK: Private

@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 3)
private let rows = [GridItem()]
@ObservedObject private var styleManager: StyleManager = .shared
}

#Preview {
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/GamepadGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -57,8 +57,9 @@ public struct GamepadGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 2)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 2)
}

#Preview {
Expand Down
4 changes: 2 additions & 2 deletions Modules/ContentKit/Sources/Views/ResourceFileView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -51,10 +51,10 @@ public struct ResourceFileView: View {

// MARK: Internal

let resource: Category.Resource

@State var isPresented: Bool = false

let resource: Category.Resource

// MARK: Private

@State private var url: URL?
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/ResourceGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -40,8 +40,9 @@ public struct ResourceGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 2)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 2)
}

#Preview {
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/SkillsGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -73,8 +73,9 @@ public struct SkillsGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 3)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 3)
}

// MARK: - l10n.SkillsGridView
Expand Down
4 changes: 2 additions & 2 deletions Modules/ContentKit/Sources/Views/StoryDetailsView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -166,15 +166,15 @@ public struct StoryDetailsView: View {

// MARK: Private

private let story: Story

@State private var selectedAuthor: Author?
@State private var selectedSkill: Skill?

@ObservedObject private var styleManager: StyleManager = .shared

@StateObject private var rootAccountViewModel = RootAccountManagerViewModel()
@StateObject private var caregiverManagerViewModel = CaregiverManagerViewModel()

private let story: Story
}

// MARK: - l10n.StoryDetailsView
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/StoryGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -63,8 +63,9 @@ public struct StoryGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 3)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 3)
}

#Preview {
Expand Down
3 changes: 2 additions & 1 deletion Modules/ContentKit/Sources/Views/SubskillsGridView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -97,8 +97,9 @@ public struct SubskillsGridView: View {

// MARK: Private

private let columns = Array(repeating: GridItem(), count: 2)
@ObservedObject private var styleManager: StyleManager = .shared

private let columns = Array(repeating: GridItem(), count: 2)
}

#Preview {
Expand Down
4 changes: 2 additions & 2 deletions Modules/DesignKit/Sources/Views/TagView.swift
Original file line number Diff line number Diff line change
Expand Up @@ -36,11 +36,11 @@ public struct TagView: View {

// MARK: Private

@ObservedObject private var styleManager: StyleManager = .shared

private let title: String
private let systemImage: String
private let action: (() -> Void)?

@ObservedObject private var styleManager: StyleManager = .shared
}

#Preview {
Expand Down
1 change: 1 addition & 0 deletions Modules/FirebaseKit/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -20,6 +20,7 @@ let project = Project.module(
.external(name: "FirebaseAnalytics"),
.external(name: "FirebaseAuth"),
.external(name: "FirebaseAuthCombine-Community"),
.external(name: "FirebaseCore"),
.external(name: "FirebaseCrashlytics"),
.external(name: "FirebaseFirestore"),
.external(name: "FirebaseFirestoreCombine-Community"),
Expand Down
1 change: 1 addition & 0 deletions Modules/GameEngineKit/Project.swift
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ let project = Project.module(
.project(target: "UtilsKit", path: Path("../../Modules/UtilsKit")),

.external(name: "AudioKit"),
.external(name: "Lottie"),
.external(name: "SVGView"),
.external(name: "SwiftUIJoystick"),
]
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,11 @@ struct ActionButtonObserve: View {

// MARK: Internal

@Binding var imageWasTapped: Bool

let image: String
let isSFSymbol: Bool

@Binding var imageWasTapped: Bool

var body: some View {
Button {
withAnimation {
Expand Down
Loading

0 comments on commit 40ded88

Please sign in to comment.