Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yann/refactor/ble/unique char for magic card #1441

Merged
merged 3 commits into from
Jun 21, 2024
Merged

Yann/refactor/ble/unique char for magic card #1441

merged 3 commits into from
Jun 21, 2024

Conversation

YannLocatelli
Copy link
Member

@YannLocatelli YannLocatelli commented Jun 20, 2024 •
edited
Loading

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Jun 20, 2024
@YannLocatelli YannLocatelli self-assigned this Jun 20, 2024
@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/unique-char-for-magic-card branch from ba67b53 to 9878f92 Compare June 20, 2024 15:07
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/unique-char-for-magic-card branch from bbe73ba to c312d84 Compare June 21, 2024 09:01
@YannLocatelli YannLocatelli marked this pull request as ready for review June 21, 2024 09:01
@YannLocatelli YannLocatelli requested a review from ladislas June 21, 2024 09:01
@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/unique-char-for-magic-card branch from c312d84 to a97d222 Compare June 21, 2024 09:03
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
ladislas
ladislas requested changes Jun 21, 2024
View reviewed changes
Copy link
Member

@ladislas ladislas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

top 👍 ça simplifie pas mal :)
juste une petite request pour l'uuid

libs/BLEKit/include/internal/ServicesCharacteristics.h Outdated

namespace characteristic {
inline constexpr UUID::LongUUIDBytes_t raw_data = {"RAW_DATA"};
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

je mettrais ID+LANGUAGE ou ID_LANGUAGE

@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/unique-char-for-magic-card branch from a97d222 to 8db85ff Compare June 21, 2024 13:58
@github-actions GitHub Actions
Copy link

🔖 Version comparison

Version Same as filename Same as os_version
os 1.4.0+1718978460 ✔️ ✔️
firmware
(bootloader + os)		 1.4.0+1718978460 ✔️ ✔️

@github-actions GitHub Actions
Copy link

📈 Changes Impact Analysis Report

📌 Info

  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: OFF
base head
branch develop yann/refactor/ble/unique-char-for-magic-card
sha 3cc063b 8db85ff
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

🤖 Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 127356 (48%) ø 134788 (51%)
134788 (51%)		 28496 (5%) ø
os 398076 (25%)
397964 (25%)		 📉
-112 (0%)		 1166596 (74%)
1166708 (74%)		 81296 (15%)
81200 (15%)		 📉
-96 (0%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 398076 (18%)
397964 (18%)		 📉
-112 (0%)		 81296 (15%)
81200 (15%)		 📉
-96 (0%)
bootloader ✔️ ✅ ✅ 127356 (6%) ø 28496 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 264596 (12%) ø 18336 (3%) ø
functional_ut_core_imu ✔️ ✅ ✅ 248116 (11%) ø 18856 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 233492 (11%) ø 18328 (3%) ø
functional_ut_deep_sleep_core_lcd ✔️ ✅ ✅ 260236 (12%) ø 50344 (9%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 232212 (11%) ø 18368 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 233228 (11%) ø 18368 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 223492 (10%) ø 18296 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 225324 (10%) ø 18296 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 241996 (11%) ø 18592 (3%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 236700 (11%) ø 18584 (3%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 252316 (12%) ø 19024 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 230468 (10%) ø 18312 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 231668 (11%) ø 18312 (3%) ø
spike_lk_activity_kit ✔️ ✅ ✅ 200760 (9%) ø 53360 (10%) ø
spike_lk_audio ✔️ ✅ ✅ 85736 (4%) ø 12128 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 148516 (7%) ø 45632 (8%) ø
spike_lk_ble ✔️ ✅ ✅ 188968 (9%) ø 26392 (5%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 38984 (1%) ø 9064 (1%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 105672 (5%) ø 44064 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 38580 (1%) ø 11320 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 179944 (8%) ø 50184 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 84980 (4%) ø 11896 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 38232 (1%) ø 11208 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 42444 (2%) ø 9768 (1%) ø
spike_lk_event_queue ✔️ ✅ ✅ 37120 (1%) ø 9592 (1%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 86352 (4%) ø 11976 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 279456 (13%) ø 25320 (4%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 36608 (1%) ø 9024 (1%) ø
spike_lk_fs ✔️ ✅ ✅ 130968 (6%) ø 45472 (8%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 62084 (2%) ø 10560 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 122716 (5%) ø 44232 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 67008 (3%) ø 12048 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 36012 (1%) ø 9832 (1%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 75296 (3%) ø 12688 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 36472 (1%) ø 9064 (1%) ø
spike_lk_qdac ✔️ ✅ ✅ 40800 (1%) ø 9328 (1%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 177160 (8%) ø 47368 (9%) ø
spike_lk_rfid ✔️ ✅ ✅ 42316 (2%) ø 9032 (1%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 41692 (1%) ø 10136 (1%) ø
spike_lk_sensors_imu_lsm6dsox ✔️ ✅ ✅ 52680 (2%) ø 10360 (1%) ø
spike_lk_sensors_imu_lsm6dsox_fusion_calibration ✔️ ✅ ✅ 61148 (2%) ø 10488 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 32800 (1%) ø 9016 (1%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 34776 (1%) ø 9016 (1%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 40044 (1%) ø 9000 (1%) ø
spike_lk_serial_number ✔️ ✅ ✅ 87992 (4%) ø 11832 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 32244 (1%) ø 9168 (1%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 49552 (2%) ø 10344 (1%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 103100 (4%) ø 13112 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 49808 (2%) ø 9928 (1%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 43468 (2%) ø 10824 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 75020 (3%) ø 12384 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 30760 (1%) ø 8976 (1%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 36144 (1%) ø 10024 (1%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 31200 (1%) ø 8976 (1%) ø

🗺️ Map files diff output

LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2024-06-21 14:04:42.046649197 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2024-06-21 14:04:42.354650532 +0000
@@ -1,55 +1,55 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       626(+626) |     14(+14) |     230(+230) |
+| [fill]                     |       638(+638) |     14(+14) |     230(+230) |
 | [lib]/ActivityKit.a        |   11054(+11054) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     1974(+1974) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1652(+1652) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |       138(+138) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     6810(+6810) |       0(+0) |         0(+0) |
 | [lib]/CoreInterruptIn.a    |       118(+118) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       146(+146) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         30(+30) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       600(+600) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     8686(+8686) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1794(+1794) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       944(+944) |       0(+0) |         0(+0) |
 | [lib]/Fusion.a             |     2036(+2036) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |       876(+876) |       0(+0) |     164(+164) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       848(+848) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1070(+1070) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       700(+700) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c_nano.a             |   17812(+17812) |   200(+200) |       53(+53) |
 | [lib]/gcc.a                |     3836(+3836) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     5256(+5256) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 180294(+180294) |   773(+773) | 19667(+19667) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++_nano.a        |     5768(+5768) |       8(+8) |     176(+176) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   75918(+75918) |   108(+108) | 27614(+27614) |
-| Subtotals                  | 357080(+357080) | 2040(+2040) | 78928(+78928) |
-Total Static RAM memory (data + bss): 80968(+80968) bytes
-Total Flash memory (text + data): 359120(+359120) bytes
+| main.cpp.obj               |   75810(+75810) |   108(+108) | 27518(+27518) |
+| Subtotals                  | 356984(+356984) | 2040(+2040) | 78832(+78832) |
+Total Static RAM memory (data + bss): 80872(+80872) bytes
+Total Flash memory (text + data): 359024(+359024) bytes
 
Flash used: 397964 (18%) / total: 2097152
SRAM used: 81200 (15%) / total: 524288

@github-actions GitHub Actions
Copy link

📈 Changes Impact Analysis Report

📌 Info

  • toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
  • enable_log_debug: ON
base head
branch develop yann/refactor/ble/unique-char-for-magic-card
sha 3cc063b 8db85ff
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

🤖 Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 141604 (54%) ø 120540 (45%)
120540 (45%)		 39448 (7%) ø
os 459060 (29%)
458916 (29%)		 📉
-144 (0%)		 1105612 (70%)
1105756 (70%)		 92648 (17%)
92552 (17%)		 📉
-96 (0%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 459060 (21%)
458916 (21%)		 📉
-144 (0%)		 92648 (17%)
92552 (17%)		 📉
-96 (0%)
bootloader ✔️ ✅ ✅ 141604 (6%) ø 39448 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 280356 (13%) ø 28488 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 256404 (12%) ø 29008 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 241948 (11%) ø 28448 (5%) ø
functional_ut_deep_sleep_core_lcd ✔️ ✅ ✅ 272444 (12%) ø 60496 (11%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 244420 (11%) ø 28520 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 245444 (11%) ø 28520 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 236508 (11%) ø 28864 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 238156 (11%) ø 28448 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 254548 (12%) ø 28744 (5%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 249356 (11%) ø 28736 (5%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 260636 (12%) ø 29176 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 242700 (11%) ø 28464 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 243876 (11%) ø 28464 (5%) ø
spike_lk_activity_kit ✔️ ✅ ✅ 204424 (9%) ø 64016 (12%) ø
spike_lk_audio ✔️ ✅ ✅ 97212 (4%) ø 22712 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 158636 (7%) ø 56216 (10%) ø
spike_lk_ble ✔️ ✅ ✅ 200292 (9%) ø 37472 (7%) ø
spike_lk_bluetooth ✔️ ✅ ✅ 51116 (2%) ø 19736 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 115244 (5%) ø 54760 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 53424 (2%) ø 21896 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 190252 (9%) ø 61264 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 98248 (4%) ø 22728 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 52852 (2%) ø 21784 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 57876 (2%) ø 20344 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 49048 (2%) ø 20424 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 102260 (4%) ø 23064 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 284520 (13%) ø 35976 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 51688 (2%) ø 19736 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 134748 (6%) ø 55072 (10%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 72364 (3%) ø 21256 (4%) ø
spike_lk_lcd ✔️ ✅ ✅ 133904 (6%) ø 55064 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 81740 (3%) ø 22624 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 49648 (2%) ø 20920 (3%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 81128 (3%) ø 23216 (4%) ø
spike_lk_motors ✔️ ✅ ✅ 51208 (2%) ø 19768 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 56552 (2%) ø 20288 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 185804 (8%) ø 57936 (11%) ø
spike_lk_rfid ✔️ ✅ ✅ 49176 (2%) ø 19704 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 52360 (2%) ø 20832 (3%) ø
spike_lk_sensors_imu_lsm6dsox ✔️ ✅ ✅ 63516 (3%) ø 21056 (4%) ø
spike_lk_sensors_imu_lsm6dsox_fusion_calibration ✔️ ✅ ✅ 71180 (3%) ø 20640 (3%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 48968 (2%) ø 19736 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 49704 (2%) ø 19736 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 55512 (2%) ø 19712 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 100752 (4%) ø 22784 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 47588 (2%) ø 19752 (3%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 61300 (2%) ø 20912 (3%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 116280 (5%) ø 23816 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 64768 (3%) ø 20760 (3%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 52444 (2%) ø 21656 (4%) ø
spike_lk_wifi ✔️ ✅ ✅ 82412 (3%) ø 23048 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 31320 (1%) ø 9072 (1%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 49084 (2%) ø 20600 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 48368 (2%) ø 19824 (3%) ø

🗺️ Map files diff output

LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2024-06-21 14:04:46.273586708 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2024-06-21 14:04:46.569585968 +0000
@@ -1,55 +1,55 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       632(+632) |     14(+14) |     251(+251) |
+| [fill]                     |       620(+620) |     14(+14) |     251(+251) |
 | [lib]/ActivityKit.a        |   11054(+11054) |       0(+0) |         0(+0) |
 | [lib]/BLEKit.a             |     3672(+3672) |       0(+0) |     128(+128) |
 | [lib]/BatteryKit.a         |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1652(+1652) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       864(+864) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1120(+1120) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       544(+544) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       196(+196) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |       138(+138) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       546(+546) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     6810(+6810) |       0(+0) |         0(+0) |
 | [lib]/CoreInterruptIn.a    |       118(+118) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       146(+146) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         30(+30) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       160(+160) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       600(+600) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         28(+28) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       204(+204) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     8686(+8686) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       348(+348) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     2302(+2302) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       944(+944) |       0(+0) |         0(+0) |
 | [lib]/Fusion.a             |     2036(+2036) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |       876(+876) |       0(+0) |     164(+164) |
 | [lib]/LedKit.a             |   19050(+19050) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       848(+848) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1070(+1070) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1242(+1242) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       584(+584) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       686(+686) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1362(+1362) |     12(+12) |     132(+132) |
 | [lib]/c_nano.a             |   17702(+17702) |   200(+200) |       53(+53) |
 | [lib]/gcc.a                |     3836(+3836) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     5256(+5256) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 181520(+181520) |   773(+773) | 19755(+19755) |
 | [lib]/misc                 |       188(+188) |       4(+4) |       28(+28) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++_nano.a        |     5774(+5774) |       8(+8) |     176(+176) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 132730(+132730) |   108(+108) | 38721(+38721) |
-| Subtotals                  | 417212(+417212) | 2040(+2040) | 90272(+90272) |
-Total Static RAM memory (data + bss): 92312(+92312) bytes
-Total Flash memory (text + data): 419252(+419252) bytes
+| main.cpp.obj               | 132614(+132614) |   108(+108) | 38625(+38625) |
+| Subtotals                  | 417084(+417084) | 2040(+2040) | 90176(+90176) |
+Total Static RAM memory (data + bss): 92216(+92216) bytes
+Total Flash memory (text + data): 419124(+419124) bytes
 
Flash used: 458916 (21%) / total: 2097152
SRAM used: 92552 (17%) / total: 524288

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ladislas ladislas merged commit 7a9d14b into develop Jun 21, 2024
22 of 23 checks passed
@ladislas ladislas deleted the yann/refactor/ble/unique-char-for-magic-card branch June 21, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas requested changes

Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YannLocatelli @ladislas