Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Yann/refactor/ble/give characteristic instead of attribute handle #1361

Merged
merged 2 commits into from
Aug 26, 2024
Merged

Yann/refactor/ble/give characteristic instead of attribute handle #1361

merged 2 commits into from
Aug 26, 2024

Conversation

YannLocatelli
Copy link
Member

No description provided.

@YannLocatelli YannLocatelli added the 01 - type: task Something to do label Jan 23, 2024
@YannLocatelli YannLocatelli added this to the Future Release milestone Jan 23, 2024
@YannLocatelli YannLocatelli self-assigned this Jan 23, 2024
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@codecov Codecov
Copy link

codecov bot commented Jan 23, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (53d1a4f) 98.75% compared to head (3dbe1d4) 98.75%.

❗ Current head 3dbe1d4 differs from pull request most recent head 0cc97da. Consider uploading reports for the commit 0cc97da to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop    #1361      +/-   ##
===========================================
- Coverage    98.75%   98.75%   -0.01%     
===========================================
  Files          146      146              
  Lines         3783     3768      -15     
===========================================
- Hits          3736     3721      -15     
  Misses          47       47

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/give-characteristic-instead-of-attribute-handle branch from fd8fc23 to a0558ca Compare January 23, 2024 14:52
@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/give-characteristic-instead-of-attribute-handle branch 3 times, most recently from 3dbe1d4 to 0cc97da Compare February 5, 2024 09:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/give-characteristic-instead-of-attribute-handle branch from 0cc97da to 5def7a5 Compare August 20, 2024 08:20
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@YannLocatelli YannLocatelli force-pushed the yann/refactor/ble/give-characteristic-instead-of-attribute-handle branch from 5def7a5 to 749f934 Compare August 26, 2024 11:00
@github-actions GitHub Actions
Copy link

🔖 Version comparison

Version Same as filename Same as os_version
os 1.4.0+1724670208 ✔️ ✔️
firmware
(bootloader + os)		 1.4.0+1724670208 ✔️ ✔️

@github-actions GitHub Actions
Copy link

📈 Changes Impact Analysis Report

📌 Info

  • toolchain: Arm GNU Toolchain 13.2.rel1 (Build arm-13.7) 13.2.1 20231009
  • enable_log_debug: ON
base head
branch develop yann/refactor/ble/give-characteristic-instead-of-attribute-handle
sha 3dd931d 749f934
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

🤖 Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 140392 (53%) ø 121752 (46%)
121752 (46%)		 39760 (7%) ø
os 479124 (30%)
479028 (30%)		 📉
-96 (0%)		 1085548 (69%)
1085644 (69%)		 94296 (17%)
94280 (17%)		 📉
-16 (0%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 479124 (22%)
479028 (22%)		 📉
-96 (0%)		 94296 (17%)
94280 (17%)		 📉
-16 (0%)
bootloader ✔️ ✅ ✅ 140392 (6%) ø 39760 (7%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 275344 (13%) ø 29840 (5%) ø
functional_ut_core_imu ✔️ ✅ ✅ 264880 (12%) ø 29384 (5%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 249048 (11%) ø 29192 (5%) ø
functional_ut_deep_sleep_core_lcd ✔️ ✅ ✅ 278488 (13%) ø 61048 (11%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 251320 (11%) ø 29200 (5%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 252360 (12%) ø 29264 (5%) ø
functional_ut_deep_sleep_imu ✔️ ✅ ✅ 264576 (12%) ø 30376 (5%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 243432 (11%) ø 29384 (5%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 244952 (11%) ø 28920 (5%) ø
functional_ut_deep_sleep_rfid_kit ✔️ ✅ ✅ 253768 (12%) ø 30760 (5%) ø
functional_ut_file_manager ✔️ ✅ ✅ 261744 (12%) ø 29504 (5%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 255592 (12%) ø 29104 (5%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 269024 (12%) ø 29512 (5%) ø
functional_ut_io_expander ✔️ ✅ ✅ 249416 (11%) ø 28808 (5%) ø
functional_ut_qdac ✔️ ✅ ✅ 250656 (11%) ø 28824 (5%) ø
spike_lk_activity_kit ✔️ ✅ ✅ 206052 (9%) ø 64656 (12%) ø
spike_lk_audio ✔️ ✅ ✅ 97000 (4%) ø 23040 (4%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 158164 (7%) ø 56544 (10%) ø
spike_lk_ble ✔️ ❌ ❌ 198464 (9%)
198368 (9%)		 📉
-96 (0%)		 37800 (7%)
37792 (7%)		 📉
-8 (0%)
spike_lk_bluetooth ✔️ ✅ ✅ 50136 (2%) ø 20056 (3%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 114296 (5%) ø 55072 (10%) ø
spike_lk_color_kit ✔️ ✅ ✅ 53112 (2%) ø 22216 (4%) ø
spike_lk_command_kit ✔️ ✅ ✅ 192084 (9%) ø 61640 (11%) ø
spike_lk_config_kit ✔️ ✅ ✅ 97932 (4%) ø 23048 (4%) ø
spike_lk_coreled ✔️ ✅ ✅ 52040 (2%) ø 22104 (4%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 57116 (2%) ø 20664 (3%) ø
spike_lk_event_queue ✔️ ✅ ✅ 48720 (2%) ø 20744 (3%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 101900 (4%) ø 23392 (4%) ø
spike_lk_file_reception ✔️ ✅ ✅ 283108 (13%) ø 36296 (6%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 51372 (2%) ø 20056 (3%) ø
spike_lk_fs ✔️ ✅ ✅ 133860 (6%) ø 55392 (10%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 73864 (3%) ø 21592 (4%) ø
spike_lk_lcd ✔️ ✅ ✅ 133508 (6%) ø 55392 (10%) ø
spike_lk_led_kit ✔️ ✅ ✅ 80656 (3%) ø 22952 (4%) ø
spike_lk_log_kit ✔️ ✅ ✅ 49360 (2%) ø 21240 (4%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 83208 (3%) ø 23856 (4%) ø
spike_lk_motors ✔️ ✅ ✅ 50868 (2%) ø 20088 (3%) ø
spike_lk_qdac ✔️ ✅ ✅ 55748 (2%) ø 20608 (3%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 187300 (8%) ø 58304 (11%) ø
spike_lk_rfid ✔️ ✅ ✅ 49640 (2%) ø 20024 (3%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 52280 (2%) ø 21152 (4%) ø
spike_lk_sensors_imu ✔️ ✅ ✅ 65080 (3%) ø 21400 (4%) ø
spike_lk_sensors_imu_fusion_calibration ✔️ ✅ ✅ 72608 (3%) ø 20992 (4%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 48712 (2%) ø 20056 (3%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 49480 (2%) ø 20056 (3%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 55304 (2%) ø 20032 (3%) ø
spike_lk_serial_number ✔️ ✅ ✅ 100536 (4%) ø 23112 (4%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 47460 (2%) ø 20072 (3%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 60640 (2%) ø 21224 (4%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 115336 (5%) ø 24144 (4%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 64128 (3%) ø 21072 (4%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 52856 (2%) ø 22264 (4%) ø
spike_lk_wifi ✔️ ✅ ✅ 82004 (3%) ø 23360 (4%) ø
spike_mbed_blinky ✔️ ✅ ✅ 30972 (1%) ø 9392 (1%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 48856 (2%) ø 20920 (3%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 48080 (2%) ø 20144 (3%) ø

🗺️ Map files diff output

LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/LekaOS-map.txt	2024-08-26 11:08:10.831409309 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/LekaOS-map.txt	2024-08-26 11:08:11.135413460 +0000
@@ -1,55 +1,55 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
-| [fill]                     |       656(+656) |     10(+10) |     265(+265) |
+| [fill]                     |       652(+652) |     10(+10) |     265(+265) |
 | [lib]/ActivityKit.a        |   10916(+10916) |       0(+0) |         0(+0) |
-| [lib]/BLEKit.a             |     3864(+3864) |       0(+0) |     128(+128) |
+| [lib]/BLEKit.a             |     3866(+3866) |       0(+0) |     128(+128) |
 | [lib]/BatteryKit.a         |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1650(+1650) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       860(+860) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1158(+1158) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       634(+634) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       252(+252) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       534(+534) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     8408(+8408) |       0(+0) |         0(+0) |
 | [lib]/CoreInterruptIn.a    |       208(+208) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       146(+146) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         30(+30) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       156(+156) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       652(+652) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         24(+24) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       210(+210) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     8618(+8618) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       354(+354) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     2346(+2346) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       592(+592) |       0(+0) |         0(+0) |
 | [lib]/Fusion.a             |     2036(+2036) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |       902(+902) |       0(+0) |     164(+164) |
 | [lib]/LedKit.a             |   18972(+18972) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       878(+878) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1246(+1246) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1390(+1390) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       594(+594) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       812(+812) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1350(+1350) |     12(+12) |     132(+132) |
 | [lib]/c_nano.a             |   17260(+17260) |   192(+192) |     370(+370) |
 | [lib]/gcc.a                |     3816(+3816) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     5184(+5184) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 178708(+178708) |   769(+769) | 19755(+19755) |
 | [lib]/misc                 |       264(+264) |       4(+4) |       25(+25) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++_nano.a        |     5654(+5654) |     12(+12) |     176(+176) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               | 153570(+153570) |   128(+128) | 40025(+40025) |
-| Subtotals                  | 436704(+436704) | 2048(+2048) | 91904(+91904) |
-Total Static RAM memory (data + bss): 93952(+93952) bytes
-Total Flash memory (text + data): 438752(+438752) bytes
+| main.cpp.obj               | 153476(+153476) |   128(+128) | 40009(+40009) |
+| Subtotals                  | 436608(+436608) | 2048(+2048) | 91888(+91888) |
+Total Static RAM memory (data + bss): 93936(+93936) bytes
+Total Flash memory (text + data): 438656(+438656) bytes
 
Flash used: 479028 (22%) / total: 2097152
SRAM used: 94280 (17%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2024-08-26 11:08:19.359524054 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-ON/spike_lk_ble-map.txt	2024-08-26 11:08:19.543526411 +0000
@@ -1,19 +1,19 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       436(+436) |     11(+11) |       72(+72) |
-| [lib]/BLEKit.a          |     3848(+3848) |       0(+0) |     128(+128) |
+| [fill]                  |       442(+442) |     11(+11) |       76(+76) |
+| [lib]/BLEKit.a          |     3850(+3850) |       0(+0) |     128(+128) |
 | [lib]/CoreEventQueue.a  |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1762(+1762) |       0(+0) |         0(+0) |
 | [lib]/c_nano.a          |   13950(+13950) |   192(+192) |     370(+370) |
 | [lib]/gcc.a             |     3276(+3276) |       0(+0) |         0(+0) |
 | [lib]/m.a               |       264(+264) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 142964(+142964) |   705(+705) | 19447(+19447) |
 | [lib]/misc              |       264(+264) |       4(+4) |       25(+25) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++_nano.a     |     4994(+4994) |     12(+12) |     184(+184) |
-| main.cpp.obj            |     8582(+8582) |     92(+92) | 16238(+16238) |
-| Subtotals               | 180424(+180424) | 1016(+1016) | 36464(+36464) |
-Total Static RAM memory (data + bss): 37480(+37480) bytes
-Total Flash memory (text + data): 181440(+181440) bytes
+| main.cpp.obj            |     8478(+8478) |     92(+92) | 16226(+16226) |
+| Subtotals               | 180328(+180328) | 1016(+1016) | 36456(+36456) |
+Total Static RAM memory (data + bss): 37472(+37472) bytes
+Total Flash memory (text + data): 181344(+181344) bytes
 
Flash used: 198368 (9%) / total: 2097152
SRAM used: 37792 (7%) / total: 524288

@github-actions GitHub Actions
Copy link

📈 Changes Impact Analysis Report

📌 Info

  • toolchain: Arm GNU Toolchain 13.2.rel1 (Build arm-13.7) 13.2.1 20231009
  • enable_log_debug: OFF
base head
branch develop yann/refactor/ble/give-characteristic-instead-of-attribute-handle
sha 3dd931d 749f934
mbed mbed-os@master+fixes+gcc-11-support mbed-os@master+fixes+gcc-11-support
-std -std=c++20 -std=c++20

🤖 Firmware impact analysis

Target Flash Used (base/head) Flash Used Δ Flash Available (base/head) Static RAM (base/head) Static RAM Δ
bootloader 125972 (48%) ø 136172 (51%)
136172 (51%)		 28808 (5%) ø
os 407156 (26%)
407060 (26%)		 📉
-96 (0%)		 1157516 (73%)
1157612 (73%)		 82936 (15%)
82920 (15%)		 📉
-16 (0%)
Click to show memory sections 
| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets
  • ✔️ - existing target
  • ✨ - new target
  • ⚰️ - deleted target
  • ✅ - files are the same
  • ❌ - files are different
Target Status .bin .map Total Flash (base/head) Total Flash Δ Static RAM (base/head) Static RAM Δ
LekaOS ✔️ ❌ ❌ 407156 (19%)
407060 (19%)		 📉
-96 (0%)		 82936 (15%)
82920 (15%)		 📉
-16 (0%)
bootloader ✔️ ✅ ✅ 125972 (6%) ø 28808 (5%) ø
functional_ut_boost_ut ✔️ ✅ ✅ 259440 (12%) ø 19688 (3%) ø
functional_ut_core_imu ✔️ ✅ ✅ 256384 (12%) ø 19232 (3%) ø
functional_ut_deep_sleep_core_buffered_serial ✔️ ✅ ✅ 240424 (11%) ø 19072 (3%) ø
functional_ut_deep_sleep_core_lcd ✔️ ✅ ✅ 266072 (12%) ø 50896 (9%) ø
functional_ut_deep_sleep_core_motor ✔️ ✅ ✅ 238920 (11%) ø 19048 (3%) ø
functional_ut_deep_sleep_core_pwm ✔️ ✅ ✅ 239952 (11%) ø 19112 (3%) ø
functional_ut_deep_sleep_imu ✔️ ✅ ✅ 255968 (12%) ø 20224 (3%) ø
functional_ut_deep_sleep_log_kit ✔️ ✅ ✅ 230232 (10%) ø 18816 (3%) ø
functional_ut_deep_sleep_mbed_hal ✔️ ✅ ✅ 231944 (11%) ø 18768 (3%) ø
functional_ut_deep_sleep_rfid_kit ✔️ ✅ ✅ 248904 (11%) ø 20640 (3%) ø
functional_ut_file_manager ✔️ ✅ ✅ 249120 (11%) ø 19352 (3%) ø
functional_ut_firmware_kit ✔️ ✅ ✅ 242696 (11%) ø 18952 (3%) ø
functional_ut_imu_kit ✔️ ✅ ✅ 260488 (12%) ø 19360 (3%) ø
functional_ut_io_expander ✔️ ✅ ✅ 237008 (11%) ø 18656 (3%) ø
functional_ut_qdac ✔️ ✅ ✅ 238256 (11%) ø 18672 (3%) ø
spike_lk_activity_kit ✔️ ✅ ✅ 202156 (9%) ø 53992 (10%) ø
spike_lk_audio ✔️ ✅ ✅ 85404 (4%) ø 12456 (2%) ø
spike_lk_behavior_kit ✔️ ✅ ✅ 147880 (7%) ø 45960 (8%) ø
spike_lk_ble ✔️ ❌ ❌ 186964 (8%)
186868 (8%)		 📉
-96 (0%)		 26712 (5%)
26704 (5%)		 📉
-8 (0%)
spike_lk_bluetooth ✔️ ✅ ✅ 37912 (1%) ø 9384 (1%) ø
spike_lk_cg_animations ✔️ ✅ ✅ 104536 (4%) ø 44376 (8%) ø
spike_lk_color_kit ✔️ ✅ ✅ 38180 (1%) ø 11640 (2%) ø
spike_lk_command_kit ✔️ ✅ ✅ 181696 (8%) ø 50560 (9%) ø
spike_lk_config_kit ✔️ ✅ ✅ 84512 (4%) ø 12216 (2%) ø
spike_lk_coreled ✔️ ✅ ✅ 37332 (1%) ø 11528 (2%) ø
spike_lk_core_touch_sensor ✔️ ✅ ✅ 41584 (1%) ø 10088 (1%) ø
spike_lk_event_queue ✔️ ✅ ✅ 36652 (1%) ø 9912 (1%) ø
spike_lk_file_manager_kit ✔️ ✅ ✅ 85824 (4%) ø 12304 (2%) ø
spike_lk_file_reception ✔️ ✅ ✅ 277904 (13%) ø 25640 (4%) ø
spike_lk_flash_memory ✔️ ✅ ✅ 36184 (1%) ø 9344 (1%) ø
spike_lk_fs ✔️ ✅ ✅ 129992 (6%) ø 45784 (8%) ø
spike_lk_imu_kit ✔️ ✅ ✅ 63372 (3%) ø 10896 (2%) ø
spike_lk_lcd ✔️ ✅ ✅ 122136 (5%) ø 44560 (8%) ø
spike_lk_led_kit ✔️ ✅ ✅ 65824 (3%) ø 12376 (2%) ø
spike_lk_log_kit ✔️ ✅ ✅ 35604 (1%) ø 10152 (1%) ø
spike_lk_motion_kit ✔️ ✅ ✅ 77204 (3%) ø 13328 (2%) ø
spike_lk_motors ✔️ ✅ ✅ 36048 (1%) ø 9384 (1%) ø
spike_lk_qdac ✔️ ✅ ✅ 39956 (1%) ø 9648 (1%) ø
spike_lk_reinforcer ✔️ ✅ ✅ 178448 (8%) ø 47736 (9%) ø
spike_lk_rfid ✔️ ✅ ✅ 42580 (2%) ø 9352 (1%) ø
spike_lk_sensors_battery ✔️ ✅ ✅ 41460 (1%) ø 10456 (1%) ø
spike_lk_sensors_imu ✔️ ✅ ✅ 54048 (2%) ø 10704 (2%) ø
spike_lk_sensors_imu_fusion_calibration ✔️ ✅ ✅ 62424 (2%) ø 10840 (2%) ø
spike_lk_sensors_light ✔️ ✅ ✅ 32456 (1%) ø 9336 (1%) ø
spike_lk_sensors_microphone ✔️ ✅ ✅ 34448 (1%) ø 9336 (1%) ø
spike_lk_sensors_temperature_humidity ✔️ ✅ ✅ 39716 (1%) ø 9320 (1%) ø
spike_lk_serial_number ✔️ ✅ ✅ 87636 (4%) ø 12160 (2%) ø
spike_lk_ticker_timeout ✔️ ✅ ✅ 31968 (1%) ø 9488 (1%) ø
spike_lk_touch_sensor_kit ✔️ ✅ ✅ 48688 (2%) ø 10656 (2%) ø
spike_lk_update_process_app_base ✔️ ✅ ✅ 102052 (4%) ø 13440 (2%) ø
spike_lk_update_process_app_update ✔️ ✅ ✅ 49052 (2%) ø 10240 (1%) ø
spike_lk_watchdog_isr ✔️ ✅ ✅ 43696 (2%) ø 11440 (2%) ø
spike_lk_wifi ✔️ ✅ ✅ 74492 (3%) ø 12696 (2%) ø
spike_mbed_blinky ✔️ ✅ ✅ 30404 (1%) ø 9296 (1%) ø
spike_mbed_watchdog_ticker_vs_thread ✔️ ✅ ✅ 35780 (1%) ø 10344 (1%) ø
spike_stl_cxxsupport ✔️ ✅ ✅ 30860 (1%) ø 9296 (1%) ø

🗺️ Map files diff output

LekaOS (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2024-08-26 11:08:19.255249474 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/LekaOS-map.txt	2024-08-26 11:08:19.531252752 +0000
@@ -1,55 +1,55 @@
 | Module                     |           .text |       .data |          .bss |
 |----------------------------|-----------------|-------------|---------------|
 | [fill]                     |       674(+674) |     10(+10) |     245(+245) |
 | [lib]/ActivityKit.a        |   10916(+10916) |       0(+0) |         0(+0) |
-| [lib]/BLEKit.a             |     2158(+2158) |       0(+0) |         0(+0) |
+| [lib]/BLEKit.a             |     2160(+2160) |       0(+0) |         0(+0) |
 | [lib]/BatteryKit.a         |       360(+360) |       0(+0) |         0(+0) |
 | [lib]/BehaviorKit.a        |     1650(+1650) |   460(+460) |         0(+0) |
 | [lib]/ColorKit.a           |       860(+860) |       0(+0) |         0(+0) |
 | [lib]/CommandKit.a         |     1158(+1158) |       0(+0) |         0(+0) |
 | [lib]/CoreBattery.a        |       634(+634) |       0(+0) |         0(+0) |
 | [lib]/CoreBufferedSerial.a |       252(+252) |       0(+0) |         0(+0) |
 | [lib]/CoreEventFlags.a     |       130(+130) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a     |         44(+44) |       0(+0) |         0(+0) |
 | [lib]/CoreFlashMemory.a    |       534(+534) |       0(+0) |         0(+0) |
 | [lib]/CoreI2C.a            |         36(+36) |       0(+0) |         0(+0) |
 | [lib]/CoreIMU.a            |     8408(+8408) |       0(+0) |         0(+0) |
 | [lib]/CoreInterruptIn.a    |       208(+208) |       0(+0) |         0(+0) |
 | [lib]/CoreMCU.a            |         16(+16) |       0(+0) |         0(+0) |
 | [lib]/CoreMotor.a          |       146(+146) |       0(+0) |         0(+0) |
 | [lib]/CoreMutex.a          |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/CorePwm.a            |         30(+30) |       0(+0) |         0(+0) |
 | [lib]/CoreQSPI.a           |       156(+156) |       0(+0) |         0(+0) |
 | [lib]/CoreRFIDReader.a     |       652(+652) |       0(+0) |         0(+0) |
 | [lib]/CoreSPI.a            |         24(+24) |       0(+0) |         0(+0) |
 | [lib]/CoreSTM32Hal.a       |       930(+930) |       0(+0) |         0(+0) |
 | [lib]/CoreTimeout.a        |       210(+210) |       0(+0) |         0(+0) |
 | [lib]/CoreVideo.a          |     8618(+8618) |       1(+1) | 30800(+30800) |
 | [lib]/CriticalSection.a    |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/EventLoopKit.a       |       354(+354) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a     |     1834(+1834) |       0(+0) |         0(+0) |
 | [lib]/FirmwareKit.a        |       592(+592) |       0(+0) |         0(+0) |
 | [lib]/Fusion.a             |     2036(+2036) |       0(+0) |         0(+0) |
 | [lib]/HelloWorld.a         |         94(+94) |       0(+0) |         0(+0) |
 | [lib]/IMUKit.a             |       902(+902) |       0(+0) |     164(+164) |
 | [lib]/LedKit.a             |   18972(+18972) |       0(+0) |       20(+20) |
 | [lib]/MotionKit.a          |       878(+878) |       0(+0) |         0(+0) |
 | [lib]/RFIDKit.a            |     1246(+1246) |       0(+0) |         8(+8) |
 | [lib]/ReinforcerKit.a      |     1390(+1390) |   460(+460) |         0(+0) |
 | [lib]/SerialNumberKit.a    |       594(+594) |       0(+0) |         0(+0) |
 | [lib]/Utils.a              |         34(+34) |       0(+0) |         0(+0) |
 | [lib]/VideoKit.a           |       812(+812) |       0(+0) |       36(+36) |
 | [lib]/bootutil.a           |     1350(+1350) |     12(+12) |     132(+132) |
 | [lib]/c_nano.a             |   17368(+17368) |   192(+192) |     370(+370) |
 | [lib]/gcc.a                |     3816(+3816) |       0(+0) |         0(+0) |
 | [lib]/m.a                  |     5184(+5184) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a     | 177486(+177486) |   769(+769) | 19667(+19667) |
 | [lib]/misc                 |       264(+264) |       4(+4) |       25(+25) |
 | [lib]/nosys.a              |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++_nano.a        |     5654(+5654) |     12(+12) |     176(+176) |
 | __/__                      |       108(+108) |       0(+0) |         0(+0) |
-| main.cpp.obj               |   85636(+85636) |   128(+128) | 28917(+28917) |
-| Subtotals                  | 365456(+365456) | 2048(+2048) | 80560(+80560) |
-Total Static RAM memory (data + bss): 82608(+82608) bytes
-Total Flash memory (text + data): 367504(+367504) bytes
+| main.cpp.obj               |   85538(+85538) |   128(+128) | 28901(+28901) |
+| Subtotals                  | 365360(+365360) | 2048(+2048) | 80544(+80544) |
+Total Static RAM memory (data + bss): 82592(+82592) bytes
+Total Flash memory (text + data): 367408(+367408) bytes
 
Flash used: 407060 (19%) / total: 2097152
SRAM used: 82920 (15%) / total: 524288
spike_lk_ble (click to expand) 
--- build_artifacts/base_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2024-08-26 11:08:27.819352383 +0000
+++ build_artifacts/head_ref-build-enable_log_debug-OFF/spike_lk_ble-map.txt	2024-08-26 11:08:27.991354160 +0000
@@ -1,18 +1,18 @@
 | Module                  |           .text |       .data |          .bss |
 |-------------------------|-----------------|-------------|---------------|
-| [fill]                  |       422(+422) |     11(+11) |       68(+68) |
-| [lib]/BLEKit.a          |     2124(+2124) |       0(+0) |         0(+0) |
+| [fill]                  |       424(+424) |     11(+11) |       72(+72) |
+| [lib]/BLEKit.a          |     2126(+2126) |       0(+0) |         0(+0) |
 | [lib]/CoreEventQueue.a  |         76(+76) |       0(+0) |         0(+0) |
 | [lib]/CriticalSection.a |           8(+8) |       0(+0) |         0(+0) |
 | [lib]/FileManagerKit.a  |     1762(+1762) |       0(+0) |         0(+0) |
 | [lib]/c_nano.a          |   14058(+14058) |   192(+192) |     370(+370) |
 | [lib]/gcc.a             |     2940(+2940) |       0(+0) |         0(+0) |
 | [lib]/mbed-os-static.a  | 138988(+138988) |   705(+705) | 19323(+19323) |
 | [lib]/misc              |       264(+264) |       4(+4) |       25(+25) |
 | [lib]/nosys.a           |         32(+32) |       0(+0) |         0(+0) |
 | [lib]/stdc++_nano.a     |     4682(+4682) |     12(+12) |     184(+184) |
-| main.cpp.obj            |     5340(+5340) |     92(+92) |   5414(+5414) |
-| Subtotals               | 170696(+170696) | 1016(+1016) | 25384(+25384) |
-Total Static RAM memory (data + bss): 26400(+26400) bytes
-Total Flash memory (text + data): 171712(+171712) bytes
+| main.cpp.obj            |     5240(+5240) |     92(+92) |   5402(+5402) |
+| Subtotals               | 170600(+170600) | 1016(+1016) | 25376(+25376) |
+Total Static RAM memory (data + bss): 26392(+26392) bytes
+Total Flash memory (text + data): 171616(+171616) bytes
 
Flash used: 186868 (8%) / total: 2097152
SRAM used: 26704 (5%) / total: 524288

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@ladislas ladislas merged commit fa3b034 into develop Aug 26, 2024
21 checks passed
@ladislas ladislas deleted the yann/refactor/ble/give-characteristic-instead-of-attribute-handle branch August 26, 2024 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladislas ladislas ladislas approved these changes

Assignees

@YannLocatelli YannLocatelli

Labels
01 - type: task Something to do
Projects
None yet
Milestone
Future Release
Development

Successfully merging this pull request may close these issues.
2 participants
@YannLocatelli @ladislas