⚡ (BLE): Update connection parameters #1353

YannLocatelli · 2024-01-10T14:00:04Z

For current LekaUpdater version, going from 876s to 684s (-22%)

github-actions · 2024-01-10T14:08:38Z

🔖 Version comparison

	Version	Same as filename	Same as os_version
os	`1.4.0+1715327914`	✔️	✔️
firmware (bootloader + os)	`1.4.0+1715327914`	✔️	✔️

github-actions · 2024-01-10T14:10:48Z

📈 Changes Impact Analysis Report

📌 Info

toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: OFF

	`base`	`head`
branch	`develop`	`yann/feature/ble/update-connection-parameters`
sha	`aac033c`	`54815c0`
mbed	`mbed-os@master+fixes+gcc-11-support`	`mbed-os@master+fixes+gcc-11-support`
`-std`	`-std=c++20`	`-std=c++20`

🤖 Firmware impact analysis

Target	Flash Used (base/head)	Flash Used Δ	Flash Available (base/head)	Static RAM (base/head)	Static RAM Δ
bootloader	170904 (65%)	ø	91240 (34%) 91240 (34%)	30952 (5%)	ø
os	444728 (28%)	ø	1119944 (71%) 1119944 (71%)	83384 (15%)	ø

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	444728 (21%)	ø	83384 (15%)	ø
bootloader	✔️	✅	✅	170904 (8%)	ø	30952 (5%)	ø
functional_ut_boost_ut	✔️	✅	✅	394140 (18%)	ø	20456 (3%)	ø
functional_ut_core_imu	✔️	✅	✅	377656 (18%)	ø	20968 (3%)	ø
functional_ut_deep_sleep_core_buffered_serial	✔️	✅	✅	362984 (17%)	ø	20440 (3%)	ø
functional_ut_deep_sleep_core_lcd	✔️	✅	✅	389572 (18%)	ø	52456 (10%)	ø
functional_ut_deep_sleep_core_motor	✔️	✅	✅	361532 (17%)	ø	20480 (3%)	ø
functional_ut_deep_sleep_core_pwm	✔️	✅	✅	362564 (17%)	ø	20480 (3%)	ø
functional_ut_deep_sleep_log_kit	✔️	✅	✅	352568 (16%)	ø	20408 (3%)	ø
functional_ut_deep_sleep_mbed_hal	✔️	✅	✅	354344 (16%)	ø	20408 (3%)	ø
functional_ut_file_manager	✔️	✅	✅	376272 (17%)	ø	20696 (3%)	ø
functional_ut_firmware_kit	✔️	✅	✅	367084 (17%)	ø	20688 (3%)	ø
functional_ut_imu_kit	✔️	✅	✅	381572 (18%)	ø	21144 (4%)	ø
functional_ut_io_expander	✔️	✅	✅	359576 (17%)	ø	20424 (3%)	ø
functional_ut_qdac	✔️	✅	✅	360744 (17%)	ø	20424 (3%)	ø
spike_lk_activity_kit	✔️	✅	✅	242208 (11%)	ø	55816 (10%)	ø
spike_lk_audio	✔️	✅	✅	127092 (6%)	ø	14592 (2%)	ø
spike_lk_behavior_kit	✔️	✅	✅	190096 (9%)	ø	48096 (9%)	ø
spike_lk_ble	✔️	✅	✅	230112 (10%)	ø	28488 (5%)	ø
spike_lk_bluetooth	✔️	✅	✅	82948 (3%)	ø	11544 (2%)	ø
spike_lk_cg_animations	✔️	✅	✅	146984 (7%)	ø	46536 (8%)	ø
spike_lk_color_kit	✔️	✅	✅	65840 (3%)	ø	13744 (2%)	ø
spike_lk_command_kit	✔️	✅	✅	221384 (10%)	ø	52640 (10%)	ø
spike_lk_config_kit	✔️	✅	✅	127324 (6%)	ø	14360 (2%)	ø
spike_lk_coreled	✔️	✅	✅	76292 (3%)	ø	13688 (2%)	ø
spike_lk_core_touch_sensor	✔️	✅	✅	80508 (3%)	ø	12248 (2%)	ø
spike_lk_event_queue	✔️	✅	✅	74800 (3%)	ø	12072 (2%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	139528 (6%)	ø	14440 (2%)	ø
spike_lk_file_reception	✔️	✅	✅	336000 (16%)	ø	27792 (5%)	ø
spike_lk_flash_memory	✔️	✅	✅	63880 (3%)	ø	11448 (2%)	ø
spike_lk_fs	✔️	✅	✅	176676 (8%)	ø	47936 (9%)	ø
spike_lk_imu_kit	✔️	✅	✅	98860 (4%)	ø	13032 (2%)	ø
spike_lk_lcd	✔️	✅	✅	164376 (7%)	ø	46688 (8%)	ø
spike_lk_led_kit	✔️	✅	✅	103424 (4%)	ø	14528 (2%)	ø
spike_lk_log_kit	✔️	✅	✅	63288 (3%)	ø	12256 (2%)	ø
spike_lk_motion_kit	✔️	✅	✅	111316 (5%)	ø	15160 (2%)	ø
spike_lk_motors	✔️	✅	✅	62808 (2%)	ø	11488 (2%)	ø
spike_lk_qdac	✔️	✅	✅	78852 (3%)	ø	11808 (2%)	ø
spike_lk_reinforcer	✔️	✅	✅	218600 (10%)	ø	49824 (9%)	ø
spike_lk_rfid	✔️	✅	✅	79180 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_battery	✔️	✅	✅	78500 (3%)	ø	12600 (2%)	ø
spike_lk_sensors_imu_lsm6dsox	✔️	✅	✅	89468 (4%)	ø	12824 (2%)	ø
spike_lk_sensors_imu_lsm6dsox_fusion_calibration	✔️	✅	✅	97916 (4%)	ø	12952 (2%)	ø
spike_lk_sensors_light	✔️	✅	✅	60056 (2%)	ø	11440 (2%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	72496 (3%)	ø	11504 (2%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	67272 (3%)	ø	11424 (2%)	ø
spike_lk_serial_number	✔️	✅	✅	133084 (6%)	ø	14304 (2%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	69052 (3%)	ø	11632 (2%)	ø
spike_lk_touch_sensor_kit	✔️	✅	✅	87896 (4%)	ø	12824 (2%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	145620 (6%)	ø	15576 (2%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	77632 (3%)	ø	12352 (2%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	80356 (3%)	ø	13288 (2%)	ø
spike_lk_wifi	✔️	✅	✅	116544 (5%)	ø	14808 (2%)	ø
spike_mbed_blinky	✔️	✅	✅	58032 (2%)	ø	11400 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	63208 (3%)	ø	12448 (2%)	ø
spike_stl_cxxsupport	✔️	✅	✅	58456 (2%)	ø	11400 (2%)	ø

🗺️ Map files diff output

No differenes where found in map files.

github-actions · 2024-01-10T14:12:12Z

📈 Changes Impact Analysis Report

📌 Info

toolchain: GNU Arm Embedded Toolchain 10.3-2021.10 - 10.3.1 20210824
enable_log_debug: ON

	`base`	`head`
branch	`develop`	`yann/feature/ble/update-connection-parameters`
sha	`aac033c`	`54815c0`
mbed	`mbed-os@master+fixes+gcc-11-support`	`mbed-os@master+fixes+gcc-11-support`
`-std`	`-std=c++20`	`-std=c++20`

🤖 Firmware impact analysis

Target	Flash Used (base/head)	Flash Used Δ	Flash Available (base/head)	Static RAM (base/head)	Static RAM Δ
bootloader	183708 (70%)	ø	78436 (29%) 78436 (29%)	41656 (7%)	ø
os	502828 (32%)	ø	1061844 (67%) 1061844 (67%)	94608 (18%)	ø

Click to show memory sections

| -          |      Hex |     Bytes |  KiB |
|------------|---------:|----------:|-----:|
| Flash      | 0x200000 | 2 097 152 | 2048 |
| SRAM       |  0x80000 |   524 288 |  512 |
| Bootloader |  0x40000 |   262 144 |  256 |
| Header     |   0x1000 |     4 096 |    4 |
| OS         | 0x17E000 | 1 564 672 | 1528 |
| Tail       |   0x1000 |     4 096 |    4 |
| Scratch    |  0x40000 |   262 144 |  256 |

🔬 Detailed impact analysis

Click to show detailed analysis for all targets

✔️ - existing target
✨ - new target
⚰️ - deleted target
✅ - files are the same
❌ - files are different

Target	Status	.bin	.map	Total Flash (base/head)	Total Flash Δ	Static RAM (base/head)	Static RAM Δ
LekaOS	✔️	✅	✅	502828 (23%)	ø	94608 (18%)	ø
bootloader	✔️	✅	✅	183708 (8%)	ø	41656 (7%)	ø
functional_ut_boost_ut	✔️	✅	✅	409276 (19%)	ø	30608 (5%)	ø
functional_ut_core_imu	✔️	✅	✅	385140 (18%)	ø	31120 (5%)	ø
functional_ut_deep_sleep_core_buffered_serial	✔️	✅	✅	370716 (17%)	ø	30560 (5%)	ø
functional_ut_deep_sleep_core_lcd	✔️	✅	✅	401172 (19%)	ø	62608 (11%)	ø
functional_ut_deep_sleep_core_motor	✔️	✅	✅	373196 (17%)	ø	30632 (5%)	ø
functional_ut_deep_sleep_core_pwm	✔️	✅	✅	374164 (17%)	ø	30632 (5%)	ø
functional_ut_deep_sleep_log_kit	✔️	✅	✅	365268 (17%)	ø	30976 (5%)	ø
functional_ut_deep_sleep_mbed_hal	✔️	✅	✅	366712 (17%)	ø	30560 (5%)	ø
functional_ut_file_manager	✔️	✅	✅	388092 (18%)	ø	30856 (5%)	ø
functional_ut_firmware_kit	✔️	✅	✅	379116 (18%)	ø	30848 (5%)	ø
functional_ut_imu_kit	✔️	✅	✅	389120 (18%)	ø	31296 (5%)	ø
functional_ut_io_expander	✔️	✅	✅	371176 (17%)	ø	30576 (5%)	ø
functional_ut_qdac	✔️	✅	✅	372344 (17%)	ø	30576 (5%)	ø
spike_lk_activity_kit	✔️	✅	✅	245028 (11%)	ø	66480 (12%)	ø
spike_lk_audio	✔️	✅	✅	137724 (6%)	ø	25168 (4%)	ø
spike_lk_behavior_kit	✔️	✅	✅	199236 (9%)	ø	58672 (11%)	ø
spike_lk_ble	✔️	✅	✅	238428 (11%)	ø	39432 (7%)	ø
spike_lk_bluetooth	✔️	✅	✅	92364 (4%)	ø	22224 (4%)	ø
spike_lk_cg_animations	✔️	✅	✅	154680 (7%)	ø	57232 (10%)	ø
spike_lk_color_kit	✔️	✅	✅	88544 (4%)	ø	24376 (4%)	ø
spike_lk_command_kit	✔️	✅	✅	230740 (11%)	ø	63728 (12%)	ø
spike_lk_config_kit	✔️	✅	✅	139780 (6%)	ø	25184 (4%)	ø
spike_lk_coreled	✔️	✅	✅	88108 (4%)	ø	24264 (4%)	ø
spike_lk_core_touch_sensor	✔️	✅	✅	93164 (4%)	ø	22824 (4%)	ø
spike_lk_event_queue	✔️	✅	✅	84152 (4%)	ø	22904 (4%)	ø
spike_lk_file_manager_kit	✔️	✅	✅	154560 (7%)	ø	25520 (4%)	ø
spike_lk_file_reception	✔️	✅	✅	339964 (16%)	ø	38448 (7%)	ø
spike_lk_flash_memory	✔️	✅	✅	86776 (4%)	ø	22216 (4%)	ø
spike_lk_fs	✔️	✅	✅	179316 (8%)	ø	57544 (10%)	ø
spike_lk_imu_kit	✔️	✅	✅	107504 (5%)	ø	23744 (4%)	ø
spike_lk_lcd	✔️	✅	✅	174572 (8%)	ø	57528 (10%)	ø
spike_lk_led_kit	✔️	✅	✅	115204 (5%)	ø	25104 (4%)	ø
spike_lk_log_kit	✔️	✅	✅	84776 (4%)	ø	23408 (4%)	ø
spike_lk_motion_kit	✔️	✅	✅	116288 (5%)	ø	25704 (4%)	ø
spike_lk_motors	✔️	✅	✅	86344 (4%)	ø	22248 (4%)	ø
spike_lk_qdac	✔️	✅	✅	91796 (4%)	ø	22768 (4%)	ø
spike_lk_reinforcer	✔️	✅	✅	226260 (10%)	ø	60400 (11%)	ø
spike_lk_rfid	✔️	✅	✅	84376 (4%)	ø	22184 (4%)	ø
spike_lk_sensors_battery	✔️	✅	✅	87480 (4%)	ø	23312 (4%)	ø
spike_lk_sensors_imu_lsm6dsox	✔️	✅	✅	98624 (4%)	ø	23536 (4%)	ø
spike_lk_sensors_imu_lsm6dsox_fusion_calibration	✔️	✅	✅	105064 (5%)	ø	23104 (4%)	ø
spike_lk_sensors_light	✔️	✅	✅	84072 (4%)	ø	22216 (4%)	ø
spike_lk_sensors_microphone	✔️	✅	✅	84824 (4%)	ø	22216 (4%)	ø
spike_lk_sensors_temperature_humidity	✔️	✅	✅	90616 (4%)	ø	22192 (4%)	ø
spike_lk_serial_number	✔️	✅	✅	145028 (6%)	ø	25256 (4%)	ø
spike_lk_ticker_timeout	✔️	✅	✅	82712 (3%)	ø	22232 (4%)	ø
spike_lk_touch_sensor_kit	✔️	✅	✅	96668 (4%)	ø	23392 (4%)	ø
spike_lk_update_process_app_base	✔️	✅	✅	157932 (7%)	ø	26288 (5%)	ø
spike_lk_update_process_app_update	✔️	✅	✅	100456 (4%)	ø	23240 (4%)	ø
spike_lk_watchdog_isr	✔️	✅	✅	87616 (4%)	ø	24136 (4%)	ø
spike_lk_wifi	✔️	✅	✅	130984 (6%)	ø	25528 (4%)	ø
spike_mbed_blinky	✔️	✅	✅	57616 (2%)	ø	11496 (2%)	ø
spike_mbed_watchdog_ticker_vs_thread	✔️	✅	✅	84176 (4%)	ø	23080 (4%)	ø
spike_stl_cxxsupport	✔️	✅	✅	83488 (3%)	ø	22304 (4%)	ø

🗺️ Map files diff output

No differenes where found in map files.

codecov · 2024-01-15T11:24:11Z

Codecov Report

Attention: Patch coverage is 86.66667% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 98.70%. Comparing base (9da3fb3) to head (dd91a42).

Files	Patch %	Lines
libs/BLEKit/source/CoreGap.cpp	83.33%	2 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #1353      +/-   ##
===========================================
- Coverage    98.75%   98.70%   -0.05%     
===========================================
  Files          146      146              
  Lines         3783     3795      +12     
===========================================
+ Hits          3736     3746      +10     
- Misses          47       49       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

sonarqubecloud · 2024-02-05T09:54:14Z

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-03-18T16:01:01Z

Quality Gate passed

Issues
2 New issues
0 Accepted issues

Measures
0 Security Hotspots
86.7% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

sonarqubecloud · 2024-05-10T08:01:20Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

YannLocatelli added the 01 - type: task Something to do label Jan 10, 2024

YannLocatelli self-assigned this Jan 10, 2024

YannLocatelli force-pushed the yann/feature/ble/update-connection-parameters branch from 35f2040 to 875e349 Compare January 15, 2024 11:10

YannLocatelli force-pushed the yann/feature/ble/update-connection-parameters branch 3 times, most recently from ad3ab39 to 47b07b1 Compare January 16, 2024 11:18

YannLocatelli requested a review from ladislas January 16, 2024 11:19

This was referenced Jan 17, 2024

Yann/feature/ble/allow larger packet reception #1356

Merged

Yann/feature/ble/improve sending speed leka/ios-monorepo#596

Closed

YannLocatelli force-pushed the yann/feature/ble/update-connection-parameters branch from 47b07b1 to 8266c54 Compare January 23, 2024 14:59

YannLocatelli force-pushed the yann/feature/ble/update-connection-parameters branch 4 times, most recently from 1e8e72c to 9f77d69 Compare February 5, 2024 09:45

YannLocatelli force-pushed the yann/feature/ble/update-connection-parameters branch from 9f77d69 to 547684d Compare March 18, 2024 15:43

YannLocatelli mentioned this pull request Mar 19, 2024

Yann/dev/v1.4.100 #1427

Closed

3 tasks

YannLocatelli force-pushed the yann/feature/ble/update-connection-parameters branch from 547684d to dd91a42 Compare May 7, 2024 15:22

⚡ (BLE): Update connection parameters

54815c0

ladislas force-pushed the yann/feature/ble/update-connection-parameters branch from dd91a42 to 54815c0 Compare May 10, 2024 07:54

ladislas merged commit aac033c into develop May 10, 2024
20 of 21 checks passed

ladislas deleted the yann/feature/ble/update-connection-parameters branch May 23, 2024 10:22

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

⚡ (BLE): Update connection parameters #1353

⚡ (BLE): Update connection parameters #1353

YannLocatelli commented Jan 10, 2024

github-actions bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

🗺️ Map files diff output

github-actions bot commented Jan 10, 2024 •

edited

Loading

🗺️ Map files diff output

codecov bot commented Jan 15, 2024 •

edited

Loading

sonarqubecloud bot commented Feb 5, 2024

sonarqubecloud bot commented Mar 18, 2024

sonarqubecloud bot commented May 10, 2024

⚡ (BLE): Update connection parameters #1353

⚡ (BLE): Update connection parameters #1353

Conversation

YannLocatelli commented Jan 10, 2024

github-actions bot commented Jan 10, 2024 • edited Loading

🔖 Version comparison

github-actions bot commented Jan 10, 2024 • edited Loading

📈 Changes Impact Analysis Report

📌 Info

🤖 Firmware impact analysis

🔬 Detailed impact analysis

🗺️ Map files diff output

github-actions bot commented Jan 10, 2024 • edited Loading

📈 Changes Impact Analysis Report

📌 Info

🤖 Firmware impact analysis

🔬 Detailed impact analysis

🗺️ Map files diff output

codecov bot commented Jan 15, 2024 • edited Loading

Codecov Report

sonarqubecloud bot commented Feb 5, 2024

Quality Gate passed

sonarqubecloud bot commented Mar 18, 2024

Quality Gate passed

sonarqubecloud bot commented May 10, 2024

Quality Gate passed

github-actions bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

github-actions bot commented Jan 10, 2024 •

edited

Loading

codecov bot commented Jan 15, 2024 •

edited

Loading