Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bad code show case #6

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

bad code show case #6

wants to merge 1 commit into from

Conversation

wenlei03
Copy link
Contributor

Try export onnx file

Try export onnx file

Signed-off-by: John <[email protected]>
@wenlei03
Copy link
Contributor Author

PR Analysis

  • 🎯 Main theme: The main theme of this PR is to add a new class SubTreeExtractor and a function ddd(). It also includes an attempt to export a model into ONNX format.
  • 📝 PR summary: This PR introduces a new class SubTreeExtractor with a forward method that adds two inputs. It also includes a function ddd() which currently has no functionality. Additionally, it attempts to export the SubTreeExtractor model into ONNX format.
  • 📌 Type of PR: Enhancement
  • 🧪 Relevant tests added: No
  • ⏱️ Estimated effort to review [1-5]: 2, The PR is relatively small and straightforward, but there are some issues that need to be addressed.
  • 🔒 Security concerns: No

PR Feedback

  • 💡 General suggestions: The PR needs to ensure that the new code added is functional and meaningful. The function ddd() currently does not perform any operation and the print statement is incomplete. The SubTreeExtractor class and its export to ONNX format could be more meaningful with some context or additional functionality.

def forward(self, x, y):
return x + y

torch.onnx.export(SubTreeExtractor(), (torch.Tensor(1,2,3,4), 1), "1.onnx")
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The torch.onnx.export function is used incorrectly. The second argument should be a tuple of torch.Tensor or a single torch.Tensor, but currently, it's a tuple of a torch.Tensor and an integer. Please correct this. [important]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant