bad code show case #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Try export onnx file Signed-off-by: John <[email protected]>
PR Analysis
PR Feedback
|
wenlei03
commented
Oct 19, 2023
| def forward(self, x, y): | ||
| return x + y | ||
|
|
||
| torch.onnx.export(SubTreeExtractor(), (torch.Tensor(1,2,3,4), 1), "1.onnx") |
There was a problem hiding this comment.
The torch.onnx.export function call should be inside a function, not in the global scope. [important]
| @@ -47,6 +47,20 @@ def _get_cutlass_path(): | |||
| raise AssertionError(f"The CUTLASS root directory not found in: {invalid_paths}") | |||
|
|
|||
|
|
|||
| def ddd(): | |||
There was a problem hiding this comment.
The print statement in function ddd is incomplete. [important]
| def forward(self, x, y): | ||
| return x + y | ||
|
|
||
| torch.onnx.export(SubTreeExtractor(), (torch.Tensor(1,2,3,4), 1), "1.onnx") |
There was a problem hiding this comment.
The torch.onnx.export function call should have a tuple of tensors as the second argument. [important]
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Try export onnx file