Snf review roy2020 #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 14, 2024 18:35
…lete or well supported (incomplete work from Greg)
…er genus-species prefix (e.g., Mt, Gm, Lj) to gene symbols
|
@ScottKalberer - I am converting this PR to draft status, since I see more changes that I would like to make. |
added 2 commits
April 15, 2024 09:39
…pecies, I separated these by species, prefixing each and moving it into its respective species directory. Also updated the templates.
|
Scott - this is ready for your review, please. However, I recommend NOT looking at each change, since I changed ALL files (79 I believe)! We can discuss the types of changes and make further corrections incrementally as needed. |
ScottKalberer
approved these changes
Apr 17, 2024
ScottKalberer
approved these changes
Apr 17, 2024
ScottKalberer
approved these changes
Apr 17, 2024
ScottKalberer
approved these changes
Apr 17, 2024
ScottKalberer
approved these changes
Apr 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I changed all yml files, adding a field "scientific_name" to each (since some files describe genes from several species), and added a two-letter prefix to each gene_symbol - for example, Gm, Mt, Lj. Also removed two very incomplete files.