Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #3

Merged
merged 3 commits into from
Oct 17, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 25 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,8 +1,30 @@
# datastore-metadata
All the LIS Datastore YAML files under one roof.
All the LIS Datastore YAML files (and some others we consider "metadata") under one roof.

This repository contains the description_[Genus]_[species].yml and README.[collection].yml files in the LIS Datastore.
This repository contains the description_[Genus]_[species].yml and README.[collection].yml files in the LIS Datastore as well as some other files handled as metadata.

Several types of files should be checked for valid format and contents prior to pushing to the datastore-metadata repository:

```
validate.sh description_genus_species YAML_FILE
validate.sh description_genus YAML_FILE
validate.sh readme YAML_FILE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This script just kept printing the usage at me, I must be doing something wrong. But, I was able to validate the yaml with executable in the parent directory as per its usage example:
./validate readme.schema.json YAML_FILE

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, were you running this on the ISU system or on one of the NCGR LIS servers? I think there's a hard-coded path in that script that may be throwing things off if not run on the former, but it should be pretty easily fixed. I put the script in the repository without thinking about it too much, but TBH I didn't actually know it existed until Steven mentioned it...

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was on one of our own, I guess that must be why.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, I think I fixed the hardcoding issue. I think that was indeed causing the behavior you described with it just printing usage. In any case, the alternate (rawer) validation method you figured out should be equivalent, the validate.sh script just does some bit of wrapping of that.

```

Each collection, also contains a CHECKSUM.[collection].md5 file (mainly because this can be used as a list of the datas files in the collection); these should be generated with the script [mdsum-folder.bash](https://github.com/legumeinfo/datastore-specifications/blob/main/scripts/mdsum-folder.bash)

After creating a new collection in the datastore (or making changes to the contents of an existing collection, which should be followed by validation as described above and an update to the CHECKSUM.[collection].md5), please be sure to:

```
git add README.[collection].yml CHECKSUM.[collection].md5
git commit (with some informative log message)
git push
```

All other files are blocked from being added to the repository in .gitignore -- except files that probably shouldn't belong in the Datastore to begin with.
Having these files up-to-date in the github repo is important not only for version control purposes, but also because some of our tools operate by cloning this repo and using the metadata as a light-weight representation of the state of the datastore. Some files (e.g. BUSCO summary files) have also been introduced into this repository to facilitate consumption by applications from a cloned version of the repository.

GitHub Actions will now validate your file(s) upon commit and will fail if they don't pass validation, although this is only apparent from the github UI (https://github.com/legumeinfo/datastore-metadata/actions) and leaves the files in the datastore proper still needing to be fixed.

For additional description of protocols related to data curation for the data store, see https://github.com/legumeinfo/datastore-specifications/tree/main/PROTOCOLS

GitHub Actions will now validate your file(s) upon commit and will fail if they don't pass validation.
Loading