change IsInside check for UnionAll to act only on the selected solid not the full collection.

[tdixon97]

Fixes #209 (at least for UnionAll), however, maybe we would like a cleaner solution than making a container with only 1 solid in it.
We also need to:

• include the tests of Possible bug in sampling from multiple sources #209 as unit tests
• check + fix + test Intersections and subtractions.

[gipert]

Yes please, can you implement SampleableObject::IsInside() and update SampleableObjectCollection::IsInside() to use it?

remage/src/RMGVertexConfinement.cc

Lines 110 to 120 in f229251

	bool RMGVertexConfinement::SampleableObjectCollection::IsInside(const G4ThreeVector& vertex) const {
	auto navigator = G4TransportationManager::GetTransportationManager()->GetNavigatorForTracking();
	for (const auto& o : data) {
	if (o.physical_volume) {
	if (navigator->LocateGlobalPointAndSetup(vertex) == o.physical_volume) return true;
	} else {
	if (o.sampling_solid->Inside(o.rotation.inverse() * vertex - o.translation)) return true;
	}
	}
	return false;
	}

[tdixon97]

Yeah I thought about it, I can definitely do this if we prefer that solution.

[gipert]

I want to setup Python for tests today, with an example, after #210 is merged.

[tdixon97]

Ok lets try to implement the tests later then, I have anyway all the python scripts I used.

[tdixon97]

Have a look now @gipert

[gipert]

Can you also update SampleableObjectCollection::IsInside() to use it?

[tdixon97]

Yes sure, I can do it later.

…

________________________________ From: Luigi Pertoldi ***@***.***> Sent: Sunday, December 29, 2024 1:04 PM To: legend-exp/remage ***@***.***> Cc: Dixon, Toby ***@***.***>; Author ***@***.***> Subject: Re: [legend-exp/remage] change IsInside check for UnionAll to act only on the selected solid not the full collection. (PR #212) ⚠ Caution: External sender Can you also update SampleableObjectCollection::IsInside() to use it? — Reply to this email directly, view it on GitHub<#212 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ANSET43G6CM5FQJZS3EKZML2H7QLVAVCNFSM6AAAAABUKVCJPWVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDKNRUG4YDEOBQGA>. You are receiving this because you authored the thread.Message ID: ***@***.***>

[gipert]

Did it no worries, I merge this and you can add/fix the rest in a future PR.