Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

include _t<n> suffix in check for existing files #198

Merged
merged 4 commits into from
Dec 17, 2024
Merged

Conversation

ManuelHu
Copy link
Collaborator

fixes #197

for root files with ntuple merging, there might still be false-positives. But we do not care that much about root files at the moment :-)

@tdixon97
Copy link
Collaborator

Should we just stop supporting the ROOT file output option, just another thing to maintain..

@ManuelHu
Copy link
Collaborator Author

We do not really "do" anything to support root. It would take more code for us to disallow root files...

@gipert
Copy link
Member

gipert commented Dec 16, 2024

I think we should keep it, if it's easy to maintain. I expect a lot of non-LEGEND users would be happy to keep all their ROOT-based post-processing infrastructure (thinking about screening facilities).

@ManuelHu ManuelHu marked this pull request as draft December 17, 2024 09:15
@ManuelHu
Copy link
Collaborator Author

This is remarkably complex, and needs more investigation... (apparently, there is no way to abort the run from the worker. And at the master BeginOfRunAction, the application cannot not know the number of threads...)

@ManuelHu ManuelHu marked this pull request as ready for review December 17, 2024 10:22
@ManuelHu ManuelHu merged commit 68276a9 into main Dec 17, 2024
7 checks passed
@ManuelHu ManuelHu deleted the output-exists-suffix branch December 17, 2024 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multithreading for .hdf5 file output
3 participants