Add double-pole-zero routines #596
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added the dpz routines based on superpulse fitting. Updated the routines to mesh with the pargen refactor changes.
|
Can we just catch the error in the optimiser in dspeed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the double-pole-zero routines written by Sam Borden (see #558 for more details). Updated the routines to work with the pargen refactor. Removed the old dpz grid search routines. Added unit tests.
Note: The dpz routine ends with an iMinuit minimization for the flatness of a dpz-corrected waveform. Currently, the double pole zero processor in dspeed throws an exception if the output is nans, During the minimization, some function calls have nan outputs. This issue will need to be addressed (either by removing the exception or forgoing the minimization step)