Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parallel to False #593

Merged
merged 4 commits into from
Nov 1, 2024
Merged

Default parallel to False #593

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
29e17a6
Default parallel to False
Nov 1, 2024
2db25b8
Changes needed for changes to LGDO iterator
Nov 1, 2024
ebed9fd
Fixed math defaults test
Nov 1, 2024
ddb25b7
style: pre-commit fixes
pre-commit-ci[bot] Nov 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/pygama/flow/data_loader.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1411,7 +1411,7 @@ def load_iterator(
)
for file in gb.groups.keys()
]
tb_names += [self.filedb.get_table_name(tier, tb)] * len(gb)
tb_names += [[self.filedb.get_table_name(tier, tb)]] * len(gb)
idx_list += [
list(entry_list.loc[i, f"{level}_idx"])
for i in gb.groups.values()
Expand Down Expand Up @@ -1509,7 +1509,7 @@ def browse(
)
for file in gb.groups.keys()
]
tb_names += [self.filedb.get_table_name(tier, tb)] * len(gb)
tb_names += [[self.filedb.get_table_name(tier, tb)]] * len(gb)
idx_list += [
list(entry_list.loc[i, f"{parent}_idx"]) for i in gb.groups.values()
]
Expand Down
2 changes: 1 addition & 1 deletion src/pygama/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ class NumbaPygamaDefaults(MutableMapping):
"""

def __init__(self) -> None:
self.parallel: bool = getenv_bool("PYGAMA_PARALLEL", default=True)
self.parallel: bool = getenv_bool("PYGAMA_PARALLEL", default=False)
self.fastmath: bool = getenv_bool("PYGAMA_FASTMATH", default=True)

def __getitem__(self, item: str) -> Any:
Expand Down
4 changes: 2 additions & 2 deletions tests/test_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@

def test_math_numba_defaults():
assert pgu.numba_math_defaults_kwargs.fastmath
assert pgu.numba_math_defaults_kwargs.parallel
assert not pgu.numba_math_defaults_kwargs.parallel

pgu.numba_math_defaults.fastmath = False
assert ~pgu.numba_math_defaults.fastmath
assert not pgu.numba_math_defaults.fastmath