Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A/E survival fractions joint fitter and ecal fix #591

Open
wants to merge 14 commits into
base: main
Choose a base branch
from

Conversation

ggmarshall
Copy link
Collaborator

@ggmarshall ggmarshall commented Oct 9, 2024

Added new joint fitter for survival fractions which is in own file.
Improved A/E fitting so now more stable, enabling run to run corrections.
Added two new modes to the time correction: average_consecutive and interpolate_consecutive
Improved docstrings
Small tweaks to ecal: upper bound on sigma and some minor sigma guess changes to remove a few edge cases.

Copy link

codecov bot commented Oct 9, 2024

Codecov Report

Attention: Patch coverage is 65.46763% with 96 lines in your changes missing coverage. Please review.

Project coverage is 48.68%. Comparing base (981877e) to head (cf8b181).
Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
src/pygama/pargen/AoE_cal.py 47.82% 48 Missing ⚠️
src/pygama/pargen/survival_fractions.py 74.15% 46 Missing ⚠️
src/pygama/pargen/energy_cal.py 75.00% 1 Missing ⚠️
src/pygama/pargen/extract_tau.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #591      +/-   ##
==========================================
- Coverage   48.80%   48.68%   -0.12%     
==========================================
  Files          59       60       +1     
  Lines        7846     7939      +93     
==========================================
+ Hits         3829     3865      +36     
- Misses       4017     4074      +57     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@erin717
Copy link
Contributor

erin717 commented Oct 22, 2024

We should consider moving the survival fraction code out of the A/E calibration script. It has enough general purpose utility beyond A/E to warrant being it's own thing.

@ggmarshall
Copy link
Collaborator Author

ggmarshall commented Oct 22, 2024

Yep I agree will move into own script

@ggmarshall ggmarshall marked this pull request as ready for review November 18, 2024 18:08
@ggmarshall
Copy link
Collaborator Author

ggmarshall commented Nov 20, 2024

@iguinn These changes should make A/E run by run corrections viable moving forward as well as cleaning up a couple of bugs and hopefully a more stable survival fraction calculation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants