-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A/E survival fractions joint fitter and ecal fix #591
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #591 +/- ##
==========================================
- Coverage 48.80% 48.68% -0.12%
==========================================
Files 59 60 +1
Lines 7846 7939 +93
==========================================
+ Hits 3829 3865 +36
- Misses 4017 4074 +57 ☔ View full report in Codecov by Sentry. |
We should consider moving the survival fraction code out of the A/E calibration script. It has enough general purpose utility beyond A/E to warrant being it's own thing. |
Yep I agree will move into own script |
@iguinn These changes should make A/E run by run corrections viable moving forward as well as cleaning up a couple of bugs and hopefully a more stable survival fraction calculation |
Added new joint fitter for survival fractions which is in own file.
Improved A/E fitting so now more stable, enabling run to run corrections.
Added two new modes to the time correction: average_consecutive and interpolate_consecutive
Improved docstrings
Small tweaks to ecal: upper bound on sigma and some minor sigma guess changes to remove a few edge cases.