Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LQ calibration updates #577

Merged
merged 7 commits into from
May 8, 2024
Merged

LQ calibration updates #577

merged 7 commits into from
May 8, 2024

Conversation

erin717
Copy link
Contributor

@erin717 erin717 commented May 7, 2024

Added the following updates to the LQ calibration routines:

  • Widened the range to use for DEP events
  • When performing the time-correction, calculate the arithmetic mean and sigma instead of trying to fit the distributions
  • Narrowed the region of drift-time values to use when calculating the drift-time correction
  • After performing the cut fit, the LQ values are now normalized by the fitted sigma. The cut value is now set to a default of 3
  • Minor changes to make the syntax consistent across all the routines.

erin717 and others added 4 commits May 7, 2024 08:41
Added a few updates to the LQ calibration:
- Widened the energy range for finding DEP events
- Switched the time_correction from doing fits of the LQ distribution to just calculating the arithmetic mean and sigma
- Added a low-value cutoff for drift time values when performing the drift time correction fit.
- Final LQ values are now normalized by the fitted sigma from the cut fit. The cut value is now set to 3.
Added the argument for the drift time parameter
@gipert gipert added the pargen Generation of analysis parameters (calibrations etc.) label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 60.41667% with 19 lines in your changes are missing coverage. Please review.

Project coverage is 50.10%. Comparing base (daa9530) to head (8e275d2).

Files Patch % Lines
src/pygama/pargen/lq_cal.py 60.41% 19 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #577      +/-   ##
==========================================
+ Coverage   50.05%   50.10%   +0.04%     
==========================================
  Files          63       63              
  Lines        7581     7596      +15     
==========================================
+ Hits         3795     3806      +11     
- Misses       3786     3790       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

erin717 and others added 3 commits May 7, 2024 09:59
@gipert gipert merged commit 36efe1a into legend-exp:main May 8, 2024
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pargen Generation of analysis parameters (calibrations etc.)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants