Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for bit compounds definitions in build_hit() config file #531

Merged
merged 9 commits into from
Dec 5, 2023

Conversation

rosannadeckert
Copy link
Contributor

added bit mask to build_hit and added test for bit mask

Copy link

codecov bot commented Nov 21, 2023

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (ad1be19) 18.17% compared to head (4af4f5d) 18.28%.

Files Patch % Lines
src/pygama/hit/build_hit.py 70.58% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #531      +/-   ##
==========================================
+ Coverage   18.17%   18.28%   +0.11%     
==========================================
  Files          33       33              
  Lines        7149     7165      +16     
==========================================
+ Hits         1299     1310      +11     
- Misses       5850     5855       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gipert gipert changed the title bit mask Add support for bit compounds definitions in build_hit() config file Nov 21, 2023
@gipert gipert added enhancement New feature or request hit Processing DSP output (calibration, classifiers...) labels Nov 21, 2023
@jasondet jasondet requested a review from willquinn December 4, 2023 17:33
@gipert gipert merged commit daa915f into legend-exp:main Dec 5, 2023
9 checks passed
@rosannadeckert rosannadeckert deleted the my-dev branch December 21, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request hit Processing DSP output (calibration, classifiers...)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants