Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to loading for trimming and updates to cal routines to handle 2 stage calibration #529

Merged
merged 11 commits into from
Dec 4, 2023

Conversation

ggmarshall
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Dec 3, 2023

Codecov Report

Attention: 180 lines in your changes are missing coverage. Please review.

Comparison is base (9432759) 20.03% compared to head (b6f9576) 19.75%.
Report is 2 commits behind head on main.

Files Patch % Lines
src/pygama/pargen/ecal_th.py 0.00% 133 Missing ⚠️
src/pygama/pargen/utils.py 0.00% 19 Missing ⚠️
src/pygama/pargen/energy_cal.py 10.52% 17 Missing ⚠️
src/pygama/pargen/energy_optimisation.py 8.33% 11 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #529      +/-   ##
==========================================
- Coverage   20.03%   19.75%   -0.28%     
==========================================
  Files          31       31              
  Lines        6479     6569      +90     
==========================================
  Hits         1298     1298              
- Misses       5181     5271      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ggmarshall ggmarshall changed the title changes to loading for trimming changes to loading for trimming and updates to cal routines to handle 2 stage calibration Dec 4, 2023
@jasondet jasondet merged commit e192c10 into legend-exp:main Dec 4, 2023
10 of 11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants