Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug fix: array_id in TCM columns must be of integer dtype #526

Merged
merged 3 commits into from
Nov 8, 2023
Merged

Conversation

gipert
Copy link
Member

@gipert gipert commented Nov 8, 2023

I have also added some basic tests.

Fixes legend-exp/legend-dataflow#26

@gipert gipert added bug Something isn't working evt build events from hit data labels Nov 8, 2023
Copy link

codecov bot commented Nov 8, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/pygama/evt/tcm.py 91.66% <50.00%> (+91.66%) ⬆️

... and 2 files with indirect coverage changes

📢 Thoughts on this report? Let us know!

@gipert gipert merged commit 9432759 into main Nov 8, 2023
9 checks passed
@gipert gipert deleted the tcm branch January 11, 2024 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working evt build events from hit data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

tcm.array_id is a double-precision float in v02.00, but was an integer in v01.06
1 participant