Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bugfix for issue 516 #520

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Conversation

MoritzNeuberger
Copy link
Contributor

  • Fixed the bug that drop_idx in build_entry_list was not filled if no cuts were set by removing the continue condition and making the default value of cut cut = "" which is changed if self.cuts is not None and level in self.cuts.keys().
  • Added continue condition if self.table_list is not None but not level in self.table_list.keys(). Otherwise the loop over tables would throw an error.

@gipert gipert added bug Something isn't working flow High-level data management labels Oct 24, 2023
@codecov
Copy link

codecov bot commented Oct 24, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Files Coverage Δ
src/pygama/flow/data_loader.py 77.07% <85.71%> (-0.02%) ⬇️

📢 Thoughts on this report? Let us know!.

@gipert
Copy link
Member

gipert commented Oct 25, 2023

This looks straightforward to me, I will merge it.

@gipert gipert merged commit a721fe1 into legend-exp:main Oct 25, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flow High-level data management
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data streams are not properly set when DataLoader.set_cuts() is not called
2 participants