-
Notifications
You must be signed in to change notification settings - Fork 56
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Address some testing and packaging issues #255
Conversation
nbstripout pre-commit hook is happy
Remove .gitattributes: the Jupyter notebook cleanup will now be run as a pre-commit hook. Will cleanup old setup.py logic in a separate pull request.
And run it to fix the existing code
Codecov Report
@@ Coverage Diff @@
## refactor #255 +/- ##
===========================================
Coverage ? 21.10%
===========================================
Files ? 20
Lines ? 2421
Branches ? 0
===========================================
Hits ? 511
Misses ? 1910
Partials ? 0 Continue to review full report at Codecov.
|
@jasondet, @iguinn: can check whether this looks fine to you? The changes are 90% due to pre-commit hooks removing trailing whitespace/newlines, checking spelling and sorting python imports – they should be innocuous. I did not enable hooks that apply formatting rules yet, we may do that once the refactoring is over and we'll maybe have more tests. The very cool thing about these hooks is that they will be run for each PR and will keep the code automatically formatted. @iguinn: I configured a pre-commit hook that strips output & metadata field from Jupyter notebooks – should be a better way to handle the issue. I will cleanup setup.py in a future PR. |
It looks good to me. I'm not going to go through and check the "viewed" box for all 89 files though ;) I just merged the previous PR, can you fix the new conflicts? |
Can this be merged? Objections? |
Lots of new features: here's a short summary of the changes.
See also #241 and #242.