Unit tests cleanup #245
Unit tests cleanup #245
Conversation
* Add OS check to get-dependencies.sh * Remove `master` and `dev` from tested branches
|
Tests are failing because of the missing |
|
Uhm I don't really expect these failures (also why not in the container?). @jasondet do you understand more than I do? |
|
Got it, now tests are finally passing. There are some warnings though: https://github.com/legend-exp/pygama/runs/5758376762?check_suite_focus=true#step:5:18 I think we should be more strict and make tests fail even on warnings. I will add this and fix them. |
with a pytest.ini file. Will switch to using .pyproject.toml in the future.
To avoid backslashes to be interpreted as escape sequences
|
Container builds will be fixed once we patch the Ubuntu container: legend-exp/legendexp_legend-base_img#5 I will configure the GitHub actions to stop testing on the CentOS container. |
Container size seems to exceed GitHub runners available storage. Will think about a solution.
|
The LEGEND container is now too big to be downloaded on GitHub Actions runners: https://github.com/legend-exp/pygama/runs/5858421030?check_suite_focus=true#step:2:237 I will temporarily disable testing in containers until we find a solution. I'll go ahead and merge this PR. |
Reorganizing and fixing the existing tests. Merge after #244 (if tests are passing!)
Reference issue: #241