Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support multiple sessions in a single browser #8496

Merged

Conversation

ehuelsmann
Copy link
Member

@ehuelsmann ehuelsmann commented Nov 10, 2024

This adds support for multiple logins in the same browser on a single server. The logins can be different companies with the same user, the same company with different users or different users with different companies.

Closes #6352

This PR needs to be enhanced to support

  • Permalinks
    Due to this PR, permalinks will have a session token embedded, which breaks the persistence
  • Change example proxy configuration files
    • nginx
    • Apache
  • Change proxy configuration file in test setup
    • GitHub
    • CircleCI
  • Change proxy configuration file in development image

@ehuelsmann ehuelsmann force-pushed the feature/multiple-browser-sessions branch 2 times, most recently from 9ff9aad to d3a3525 Compare November 16, 2024 12:25
This adds support for multiple logins in the same browser on a single
server. The logins can be different companies with the same user,
the same company with different users or different users with different
companies.

Closes ledgersmb#6352
Replaces the approach of having the session ID in the URI.

Also removes the need to have '?__action=root' from URL by using '__default'
action in erp.pm.
Remove single-line function used in a single place.
@ehuelsmann ehuelsmann force-pushed the feature/multiple-browser-sessions branch from d3a3525 to 999f08f Compare November 16, 2024 13:17
@ehuelsmann ehuelsmann force-pushed the feature/multiple-browser-sessions branch from 999f08f to 8af171c Compare November 16, 2024 13:22
@ehuelsmann ehuelsmann marked this pull request as ready for review November 16, 2024 17:20
@ehuelsmann ehuelsmann merged commit 2ee3f15 into ledgersmb:master Nov 16, 2024
24 checks passed
@ehuelsmann ehuelsmann deleted the feature/multiple-browser-sessions branch November 16, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Multiple companies cannot be used from the same browser using multiple windows or tabs
1 participant