Msw 2 #7692
Merged
Msw 2 #7692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuelsmann
approved these changes
Nov 4, 2023
There was a problem hiding this comment.
Overall, I think this does the job of moving to msw2. I'm not seeing the benefits in our tests for the API changes that msw2 created. However, I guess our tests are too small to show the benefit.
The thing I should have brought to your attention when these tests were originally developed, is that these tests use a different coding style ("modern JavaScript") than the main JS code base: it doesn't use semi-colons to terminate statements. It would have been nice to stick to one style, but I guess that's water under the bridge.
| }); | ||
|
|
||
| it("should fail on bad version", async () => { | ||
| const jsdomAlert = window.alert; // remember the jsdom alert | ||
| window.alert = jest.fn(); // provide an empty implementation for window.alert |
There was a problem hiding this comment.
Why empty? Why not capture the fact that it was called (if that's what we expect to happen)?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Msw 2 changed the API and required an adjustment of all tests.
It also enforce the validity of URL used in fetches, so we had to make sure that the current location was always set before fetching.