Factor initial data out of schema SQL file #7648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehuelsmann
changed the title
ylavoie
approved these changes
Oct 7, 2023
ehuelsmann
force-pushed
the
feature/factored-initial-data
branch
2 times, most recently
from
2e3ff6b to
88ce9b8
Compare
More importantly than having an empty schema, the data can be used (from the XML) before it's in a database...
Since no schema has been created yet, the upgrade procedure has no way to query which countries are available for selection... So instead of offering the full (translated) list, offer the list that intersects with the list of countries used to seed the schema.
ehuelsmann
force-pushed
the
feature/factored-initial-data
branch
from
88ce9b8 to
ffafb89
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.