Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove version number from cookies #7639

Merged
merged 1 commit into from
Oct 6, 2023

Conversation

ehuelsmann
Copy link
Member

Without the version number, we don't need to rename the cookie on each release, removing a major maintenance nuisance.

[ci skip]

@ehuelsmann ehuelsmann requested a review from ylavoie October 5, 2023 21:27
Copy link
Contributor

@ylavoie ylavoie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bin/ledgersmb-server.psgi Still refers to a versioned cookie.

Without the version number, we don't need to rename the
cookie on each release, removing a major maintenance
nuisance.
@ehuelsmann ehuelsmann force-pushed the cookie-without-version branch from 25fecbe to b23730e Compare October 6, 2023 07:19
@ehuelsmann
Copy link
Member Author

bin/ledgersmb-server.psgi Still refers to a versioned cookie.

Thanks! Addressed.

@ehuelsmann ehuelsmann enabled auto-merge October 6, 2023 07:35
@ehuelsmann ehuelsmann merged commit a8dd239 into ledgersmb:master Oct 6, 2023
16 checks passed
@ehuelsmann ehuelsmann deleted the cookie-without-version branch October 6, 2023 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants