Invert the 'testing-done' condition

Because skipping indicates success, even if preceded by a failing job...
ledgersmb · Oct 22, 2023 · 2697096 · 2697096
1 parent 94aa909
commit 2697096
Showing 1 changed file with 5 additions and 2 deletions.
diff --git a/.github/workflows/main.yml b/.github/workflows/main.yml
@@ -338,10 +338,13 @@ jobs:
   testing-done:
     runs-on: ubuntu-latest
     needs: [ build ]
+    if: failure()
+    # This job gets skipped on successful completion of the dependent jobs
+    # Skipped jobs are interpreted as 'success' condition in branch protection rules...
     steps:
-      - name: Done
+      - name: Failed
         run: |
-          echo "DONE!"
+          exit 1
 
   build-dev:
     if: github.event.action == 'closed' && github.event.pull_request.merged == true