fix: no wallet balance service calls #819
Merged
+61
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexp3y
requested review from
edgarkhanzadian,
pete-watters and
tigranpetrossian
pete-watters
approved these changes
Jan 17, 2025
There was a problem hiding this comment.
Nice work @alexp3y 👍
So we default to 0 and then can still handle errors appropriately via the new state then I can also filter out tokens with 0 we don't want to see client side
|
@pete-watters The balance defaults should only apply at aggregate-level calls, e.g. the aggregate SIP10 balance of |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR fixes an issue that occurs when balance services (BTC, STX, SIP10) are called with fresh app state and/or no wallets loaded (i.e. an empty array of accounts). The balance services should return a default zero balance, instead they throw errors, preventing components from rendering.
The PR also adds logic to skip the BIS xpub inscriptions request when on testnet as it isn't currently supported on the BIS testnet server and is returns a 404. The testnet server will be upgraded end of month and the request can be reinstated.