fix: android secure storage #803

edgarkhanzadian · 2025-01-13T13:49:56Z

Secure mode now works also for PIN, password, or pattern.

Things that need to get merged into this PR:

Dark mode errors out on wallet creation lottie animation for some reason fix: android lottie #812
Blur view is blocking the whole screen instead of just the mnemonic section for some reason, needs investigation fix: blur view bug #815

edgarkhanzadian · 2025-01-13T13:50:24Z

@camerow can you, please, try it on your device?

apps/mobile/src/store/key-store.ts

pete-watters · 2025-01-13T15:19:30Z

apps/mobile/src/store/key-store.ts

-      const { mnemonic, passphrase } = await mnemonicStore(fingerprint).getMnemonic();
-
-      if (!mnemonic) throw new Error('No mnemonic found for fingerprint ' + fingerprint);
+    async deriveNextAccountKeychainsFrom(


How about having two functions.

deriveNextAccountKeychainsFromFingerprint

deriveNextAccountKeychains - accepts mnemonic + passphrase and calls deriveNextAccountKeychainsFromFingerprint ?

I think that will make it cleaner and easier to follow

Yea but the problem is that i need to have mnemonic in deriveNextAccountKeychainsFromFingerprint function, such that i'd be able to get a rootKeychain there. And i'm trying not to call mnemonicStore(props.fingerprint).getMnemonic() again so that we don't display a biometrics check multiple times.

So I need to have a function that would have mnemonic, password and fingerprint received as props. But, I don't want to call that function with all of the props as i can derive fingerprint from mnemonic (using biometrics) and vice versa (without biometrics). This way, i can have an overloaded function that can either receive fingerprint or mnemonic, and with that it would be able to derive next account keychains.

pete-watters

Nice work Edgar! I added some suggestions on cleaning the code up a bit.

It would be also good to:

add a maestro test or two to confirm it works
create Linear tasks for the outstanding issues you mentioned
link this PR to the secure storage task

leather-bot · 2025-01-13T21:15:43Z

Expo Android build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/b4331ff7-f66e-4527-96af-60c95db652f5

camerow · 2025-01-13T21:18:05Z

@edgarkhanzadian I'm getting a blank dead screen when creating a new wallet from zero-state freshly installed application after enabling secure mode.

Fresh install of app
Go to settings -> Enable secure mode
Create new wallet
Black screen

After trying a few times the screen was no longer blank but the application crashes when I press the "I've backed it up" button.

leather-bot · 2025-01-13T21:24:05Z

Expo simulator build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/04e15c4b-5838-46cc-a8b2-e04461bfc5ce

edgarkhanzadian · 2025-01-14T08:38:40Z

@camerow

I'm getting a blank dead screen when creating a new wallet from zero-state freshly installed application after enabling secure mode.

yeap that's the blur view issue happening, it's happening on dev too so will fix as part of a separate PR

After trying a few times the screen was no longer blank but the application crashes when I press the "I've backed it up" button.

If that happens on dark mode, then it should be lottie related

codecov · 2025-01-14T11:39:37Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 29.07%. Comparing base (81ab5f9) to head (d8c1f7e).
Report is 1 commits behind head on dev.

Additional details and impacted files

@@           Coverage Diff           @@
##              dev     #803   +/-   ##
=======================================
  Coverage   29.07%   29.07%           
=======================================
  Files         204      204           
  Lines        8132     8132           
  Branches      560      560           
=======================================
  Hits         2364     2364           
  Misses       5768     5768

Components	Coverage Δ
bitcoin	`64.15% <ø> (ø)`
query	`12.60% <ø> (ø)`
utils	`42.64% <ø> (ø)`
crypto	`68.21% <ø> (ø)`
stacks	`71.78% <ø> (ø)`

leather-bot · 2025-01-14T12:07:47Z

Expo Android build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/f2b70112-a850-489f-86f6-a2c69ecf58b6

leather-bot · 2025-01-14T12:12:17Z

Expo simulator build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/6f168c6e-ff94-4a94-8c49-0fd98a0b4778

camerow · 2025-01-14T14:12:00Z

@edgarkhanzadian so this isn't quite testable in the current state of the app?

edgarkhanzadian · 2025-01-15T13:04:52Z

@camerow alrighty, with those 2 fixes now in, this PR should be ready for testing

leather-bot · 2025-01-15T13:11:30Z

Expo Android build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/c2220b07-5564-4dcd-aec1-1ac0d3b97ee4

leather-bot · 2025-01-15T13:14:03Z

Expo simulator build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/6acd1cfc-8868-49c4-bab7-7c5d1fdeba97

leather-bot · 2025-01-15T13:25:51Z

Expo Android build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/6d916dba-a922-452d-bdc9-2c8a04d7a948

leather-bot · 2025-01-15T13:25:53Z

Expo simulator build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/3a2d885c-49d8-4765-be9f-16c8fcc2fcfc

leather-bot · 2025-01-15T13:38:04Z

Expo Android build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/d1d35092-9ba4-4f6d-88d0-0911f780ce8e

leather-bot · 2025-01-15T13:47:50Z

Expo simulator build link: https://expo.dev/accounts/leather-wallet/projects/leather-wallet-mobile/builds/518f655e-511e-43b8-90d5-5ee5e91890f5

camerow · 2025-01-15T16:35:44Z

@edgarkhanzadian tested and this is working for me now! Nice one.

🚀

kyranjamie

Great work @edgarkhanzadian

edgarkhanzadian requested review from kyranjamie, pete-watters, camerow, fbwoolf and alter-eggo January 13, 2025 13:50

pete-watters reviewed Jan 13, 2025

View reviewed changes

apps/mobile/src/store/key-store.ts Outdated Show resolved Hide resolved

pete-watters reviewed Jan 13, 2025

View reviewed changes

pete-watters approved these changes Jan 13, 2025

View reviewed changes

camerow added the needs:demo-build Create EAS simulator build based on label label Jan 13, 2025

fbwoolf approved these changes Jan 14, 2025

View reviewed changes

This was referenced Jan 15, 2025

fix: android lottie #812

Merged

fix: blur view bug #815

Merged

edgarkhanzadian removed the needs:demo-build Create EAS simulator build based on label label Jan 15, 2025

edgarkhanzadian force-pushed the fix/android-secure-storage branch from fad950a to 0818a42 Compare January 15, 2025 14:13

kyranjamie approved these changes Jan 15, 2025

View reviewed changes

edgarkhanzadian force-pushed the fix/android-secure-storage branch from c862bdc to b3beee3 Compare January 16, 2025 12:46

fix: android secure storage

d8c1f7e

edgarkhanzadian force-pushed the fix/android-secure-storage branch from b3beee3 to d8c1f7e Compare January 16, 2025 15:05

edgarkhanzadian added this pull request to the merge queue Jan 16, 2025

Merged via the queue into dev with commit 1281837 Jan 16, 2025
13 checks passed

edgarkhanzadian deleted the fix/android-secure-storage branch January 16, 2025 17:45

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: android secure storage #803

fix: android secure storage #803

edgarkhanzadian commented Jan 13, 2025 •

edited

Loading

edgarkhanzadian commented Jan 13, 2025

pete-watters Jan 13, 2025

kyranjamie Jan 13, 2025

edgarkhanzadian Jan 14, 2025

pete-watters left a comment

leather-bot commented Jan 13, 2025

camerow commented Jan 13, 2025 •

edited

Loading

leather-bot commented Jan 13, 2025

edgarkhanzadian commented Jan 14, 2025

codecov bot commented Jan 14, 2025 •

edited

Loading

leather-bot commented Jan 14, 2025

leather-bot commented Jan 14, 2025

camerow commented Jan 14, 2025

edgarkhanzadian commented Jan 15, 2025 •

edited

Loading

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

camerow commented Jan 15, 2025

kyranjamie left a comment

fix: android secure storage #803

fix: android secure storage #803

Conversation

edgarkhanzadian commented Jan 13, 2025 • edited Loading

edgarkhanzadian commented Jan 13, 2025

pete-watters Jan 13, 2025

Choose a reason for hiding this comment

kyranjamie Jan 13, 2025

Choose a reason for hiding this comment

edgarkhanzadian Jan 14, 2025

Choose a reason for hiding this comment

pete-watters left a comment

Choose a reason for hiding this comment

leather-bot commented Jan 13, 2025

camerow commented Jan 13, 2025 • edited Loading

leather-bot commented Jan 13, 2025

edgarkhanzadian commented Jan 14, 2025

codecov bot commented Jan 14, 2025 • edited Loading

Codecov Report

leather-bot commented Jan 14, 2025

leather-bot commented Jan 14, 2025

camerow commented Jan 14, 2025

edgarkhanzadian commented Jan 15, 2025 • edited Loading

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

leather-bot commented Jan 15, 2025

camerow commented Jan 15, 2025

kyranjamie left a comment

Choose a reason for hiding this comment

edgarkhanzadian commented Jan 13, 2025 •

edited

Loading

camerow commented Jan 13, 2025 •

edited

Loading

codecov bot commented Jan 14, 2025 •

edited

Loading

edgarkhanzadian commented Jan 15, 2025 •

edited

Loading