refactor(rpc): migrate signPsbt methods
#658
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #658 +/- ##
==========================================
- Coverage 29.41% 29.41% -0.01%
==========================================
Files 175 175
Lines 6836 6840 +4
Branches 457 457
==========================================
+ Hits 2011 2012 +1
- Misses 4825 4828 +3
|
kyranjamie
force-pushed
the
refactor/migrate-sign-psbt
branch
from
82db01a to
265b449
Compare
kyranjamie
force-pushed
the
refactor/migrate-sign-psbt
branch
from
265b449 to
cf371af
Compare
kyranjamie
requested review from
edgarkhanzadian,
fbwoolf,
pete-watters and
tigranpetrossian
| signAtIndex: z | ||
| .union([z.number(), z.array(z.number())]) | ||
| .optional() | ||
| .refine(testIsNumberOrArrayOfNumbers), |
There was a problem hiding this comment.
Is this by any chance a leftover? The refinement seems to be doing the same as the two rules above.
Also curious what's the context of testIsNumberOrArrayOfNumbers being a wrapper around isNumberOrNumberList + isUndefined?
There was a problem hiding this comment.
Yeah that's a very good point, I've been in yup → zod migration mode and indeed, this is the same thing 🤔
|
@kyranjamie this should presumably undergo design review before release? We'll need a build generated for testing |
|
Is there a relevant issue to link? |
This PR migrates over all the methods used in the extension for
signPsbt. Everything we had in here was from Btckit and some properties had since changed.