-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor(rpc): migrate signPsbt
methods
#658
base: dev
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #658 +/- ##
==========================================
- Coverage 29.41% 29.41% -0.01%
==========================================
Files 175 175
Lines 6836 6840 +4
Branches 457 457
==========================================
+ Hits 2011 2012 +1
- Misses 4825 4828 +3
|
82db01a
to
265b449
Compare
265b449
to
cf371af
Compare
signAtIndex: z | ||
.union([z.number(), z.array(z.number())]) | ||
.optional() | ||
.refine(testIsNumberOrArrayOfNumbers), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this by any chance a leftover? The refinement seems to be doing the same as the two rules above.
Also curious what's the context of testIsNumberOrArrayOfNumbers
being a wrapper around isNumberOrNumberList
+ isUndefined
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah that's a very good point, I've been in yup → zod migration mode and indeed, this is the same thing 🤔
@kyranjamie this should presumably undergo design review before release? We'll need a build generated for testing |
Is there a relevant issue to link? |
This PR migrates over all the methods used in the extension for
signPsbt
. Everything we had in here was from Btckit and some properties had since changed.