-
Notifications
You must be signed in to change notification settings - Fork 355
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added the rfs transforms for cifarfs #303
base: master
Are you sure you want to change the base?
Conversation
added the rfs transforms for cifarfs (and fc100)
realted PR: #305 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR @brando90, I've added a few comments. In addition, do you want to add your contribution to CHANGELOG.md?
mode='train', | ||
download=True) | ||
valid_dataset = l2l.vision.datasets.CIFARFS(root=root, | ||
transform=data_transform, | ||
transform=train_data_transforms, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should be test_data_transforms
, right?
More than happy to. I've not done many PRs before, so I am unsure how to do it though. Do I create another file in the PR itself or edit that file in this PR or create a new PR with the CHANGELOG.md? |
is there something missing? :) |
wouldn't it be better to have as an option for data sets to receive the transforms e.g.
adding the option there? |
I believe the proposed changes haven't been pushed? You'd need to clone the branch, incorporate them, and push. As for the transforms, I'd rather not include them in the benchmarks too. |
not sure which ones you referring too but I can see the changes here: https://github.com/learnables/learn2learn/pull/303/files |
I meant the changes requested before merging (removing contented docs, swapping train augmentation for test, etc). As soon as these ones are pushed, we can run the tests. |
added the rfs transforms for cifarfs
Description
Fixes #[ISSUE NUMBER]
Added the data transform according to rfs paper for cifarfs, fc100 original rfs code: https://github.com/WangYueFt/rfs/blob/f8c837ba93c62dd0ac68a2f4019c619aa86b8421/dataset/cifar.py#L26
Contribution Checklist
If your contribution modifies code in the core library (not docs, tests, or examples), please fill the following checklist.