Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latestblog #201

Merged
merged 6 commits into from
Dec 31, 2024
Merged

Latestblog #201

merged 6 commits into from
Dec 31, 2024

Conversation

GabrielaReyna
Copy link
Contributor

@GabrielaReyna GabrielaReyna commented Dec 17, 2024

I have made the following changes:

  • Added the "latest blog" section (BlogPostCardset component) to cheerp.io and cheerpx.io Each section should only show the latest blogpost of the product. For example, for CheerpX.io only CheerpX related posts and so on. Labs should show the latest posts of all the products on the latest news section.
  • The BlogPostSet component colors on the URL post title should match the color of the website (primary-400 for labs, cheerp green for cheerp and blue-ish for cheerpX).

Please when reviewing this PR make sure to test and check works as intended.

@GabrielaReyna GabrielaReyna marked this pull request as ready for review December 17, 2024 17:26
@AtibQur
Copy link
Contributor

AtibQur commented Dec 21, 2024

@GabrielaReyna for every product, the latest blog posts are showing for that specific product. Labs is showing every product.

When hovering or clicking on the post title, it does not show a different color for each product for me. Could you check this again and let me know if it's still working for you?

@GabrielaReyna
Copy link
Contributor Author

Could you please specify in which page?
I checked and it works as I was expecting:

  • Labs: link hovers of blog post card set are pink)
  • Cheerp.io (link hovers of blog post card set are green)
  • Cheerpx.io (link hovers of blog post card set are grayish blue)

I adjusted the size of the container of the blog post card set, it was too narrow on 13" screens.

@AtibQur AtibQur merged commit f01f506 into main Dec 31, 2024
9 checks passed
@AtibQur AtibQur deleted the latestblog branch December 31, 2024 10:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants