Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Index list #196

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

Index list #196

wants to merge 5 commits into from

Conversation

AtibQur
Copy link
Contributor

@AtibQur AtibQur commented Dec 9, 2024

No description provided.

description: Purpose and usage of index.list
---

## What is `index.list`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having a separate reference seems to me excessively verbose and a poor fit in the current API reference structure.
image

index.list is not an API, why should it be there?

Let's try something simpler. The example and screenshots are certainly not required. Add a new section to the WebDevice reference instead with a shorted version of this guide.

The most important thing that is' missing is to explain people how to create this file. Try to build a find oneliner that creates the file. Keep in mind that you cannot simply do ls > index.list since index.list will then spuriously appear in the listing. The combination of ls > .index.list + mv .index.list index.list might work.

Copy link
Contributor

@GabrielaReyna GabrielaReyna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel like part of the content in this guide should go to the Reference (e.g ´CheerpX.WebDevice.create()´etc with parameters and returns) It is good we have this guide but it is extra clear if the explanations can link to the reference as well.


To be able to list the files, CheerpX will look for a file called index.list in the directory and each of its subdirectories. The file should contain a newline separated list of all files and folders contained in the directory.
### Why use an `index.list` File?
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please do not capitalize words that are not the first word or aren't proper names. Please apply this correction to all the titles and subtitles of this guide.

@AtibQur
Copy link
Contributor Author

AtibQur commented Dec 22, 2024

@GabrielaReyna Do you want me to add a reference to .create for all the devices from the Files and filesystems guide? I think removing information would make the guide lose its purpose.

I could add all the device information in the .create reference section with information on how to create the devices but I feel like that would be double the information. What do you think?

@GabrielaReyna
Copy link
Contributor

We will add this to the reference when we re-organise the structure, we can merge this PR as it is for now. if the other requests have been fulfilled.

@GabrielaReyna
Copy link
Contributor

Please ping me once Alessandro approves the technical changes.

@AtibQur AtibQur requested a review from alexp-sssup December 23, 2024 16:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants