Atomics #171
Merged
Atomics #171
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuri91
requested changes
Nov 1, 2023
yuri91
requested changes
Dec 12, 2023
Maqrkk
force-pushed
the
atomics
branch
2 times, most recently
from
126a70d to
5b7aa99
Compare
yuri91
reviewed
Dec 13, 2023
yuri91
approved these changes
Dec 13, 2023
yuri91
approved these changes
Jan 2, 2024
yuri91
requested changes
Feb 1, 2024
yuri91
reviewed
Feb 8, 2024
yuri91
approved these changes
Feb 23, 2024
AtomicRMW is marked as not inlineable. AtomicCmpXchg is marked as not inlineable. The compare operand to an AtomicCmpXchg instruction may not be inlined.
This pass is meant to remove atomics by invoking the existing LowerAtomicPass only on genericjs functions.
TypeOptimizer would create new named structs as copies of literal structs. This caused a problem in the case of literal structs that are the result of a cmpxchg instruction. During inlining, these create their original return types, and those would conflict with the ones that went through TypeOptimizer. In turn, we needed a tiny fix in isJSExportedType in order for the literal structs not to cause a crash.
The Mutex uses a 64-bit value to store it's state. It then does atomic operations on this value, resulting in 64-bit atomic operations. These are not supported in AsmJS, so for now we've disabled the Mutex.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for atomics